PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #3603 from matrix-org/jryans/remove-descend-hints

Browse source 
Remove lint comments about no-descending-specificity
This commit is contained in:
J. Ryan Stinnett 2019-11-08 18:58:14 +02:00 committed by GitHub
commit eff4c36e6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
res/css/structures/_AutoHideScrollbar.scss
View file

@ -14,12 +14,11 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
/* This file has CSS for both native and non-native scrollbars in an /* This file has CSS for both native and non-native scrollbars in an order
* order that's fairly logic to read but violates stylelints descending * that's fairly logical to read but duplicates a selector to separate the
* specificity rule, so turn it off for this file. It also duplicates * hiding/showing from the sizing.
* a selector to separate the hiding/showing from the sizing.
*/ */
/* stylelint-disable no-descending-specificity, no-duplicate-selectors */ /* stylelint-disable no-duplicate-selectors */
/* /*
1. for browsers that support native overlay auto-hiding scrollbars 1. for browsers that support native overlay auto-hiding scrollbars

4
res/css/views/dialogs/_DevtoolsDialog.scss
View file

@ -135,9 +135,6 @@ limitations under the License.
} }
} }
/* Ordering this block by specificity would require breaking it up into several
chunks, which seems like it would be more confusing to read. */
/* stylelint-disable no-descending-specificity */
.mx_DevTools_tgl-flip { .mx_DevTools_tgl-flip {
+ .mx_DevTools_tgl-btn { + .mx_DevTools_tgl-btn {
padding: 2px; padding: 2px;
@ -192,4 +189,3 @@ limitations under the License.
} }
} }
} }
/* stylelint-enable no-descending-specificity */

4
res/css/views/elements/_Field.scss
View file

@ -148,9 +148,6 @@ limitations under the License.
color: $greyed-fg-color; color: $greyed-fg-color;
} }
/* Ordering this block by specificity would require breaking it up into several
chunks, which seems like it would be more confusing to read. */
/* stylelint-disable no-descending-specificity */
.mx_Field_valid { .mx_Field_valid {
&.mx_Field, &.mx_Field,
&.mx_Field:focus-within { &.mx_Field:focus-within {
@ -174,7 +171,6 @@ limitations under the License.
color: $input-invalid-border-color; color: $input-invalid-border-color;
} }
} }
/* stylelint-enable no-descending-specificity */
.mx_Field_tooltip { .mx_Field_tooltip {
margin-top: -12px; margin-top: -12px;

5
res/css/views/rooms/_EventTile.scss
View file

@ -561,9 +561,6 @@ div.mx_EventTile_notSent.mx_EventTile_redacted .mx_UnknownBody {
/* end of overrides */ /* end of overrides */
/* Ordering this block by specificity would require breaking it up into several
chunks, which seems like it would be more confusing to read. */
/* stylelint-disable no-descending-specificity */
.mx_MatrixChat_useCompactLayout { .mx_MatrixChat_useCompactLayout {
.mx_EventTile { .mx_EventTile {
padding-top: 4px; padding-top: 4px;
@ -641,5 +638,3 @@ div.mx_EventTile_notSent.mx_EventTile_redacted .mx_UnknownBody {
} }
} }
} }
/* stylelint-enable no-descending-specificity */