PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Improve combining diacritics in Chrome (#8687)

Browse source 
This makes all but 9 of U+20D0 to U+20F0 combine
correctly on Chrome. See also
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898
This commit is contained in:
Matthew Hodgson 2022-05-25 04:37:08 +01:00 committed by GitHub
parent e20ae18378
commit ef69946440
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
res/themes/legacy-light/css/_legacy-light.scss
View file

@ -1,16 +1,18 @@
// XXX: check this?
/* Nunito lacks combining diacritics, so these will fall through /* Nunito lacks combining diacritics, so these will fall through
to the next font. Helevetica's diacritics however do not combine to the next font. Helevetica's diacritics sometimes do not combine
nicely (on OSX, at least) and result in a huge horizontal mess. nicely (on OSX, at least) and result in a huge horizontal mess.
Arial empirically gets it right, hence prioritising Arial here. */ Arial empirically gets it right, hence prioritising Arial here.
We also include STIXGeneral explicitly to support a wider range
of combining diacritics (Chrome fails without it, as per
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898) */
/* We fall through to Twemoji for emoji rather than falling through /* We fall through to Twemoji for emoji rather than falling through
to native Emoji fonts (if any) to ensure cross-browser consistency */ to native Emoji fonts (if any) to ensure cross-browser consistency */
/* Noto Color Emoji contains digits, in fixed-width, therefore causing /* Noto Color Emoji contains digits, in fixed-width, therefore causing
digits in flowed text to stand out. digits in flowed text to stand out.
TODO: Consider putting all emoji fonts to the end rather than the front. */ TODO: Consider putting all emoji fonts to the end rather than the front. */
$font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Arial', 'Helvetica', sans-serif, 'Noto Color Emoji'; $font-family: 'Nunito', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'STIXGeneral', 'Arial', 'Helvetica', sans-serif, 'Noto Color Emoji';
$monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Courier', monospace, 'Noto Color Emoji'; $monospace-font-family: 'Inconsolata', 'Twemoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'STIXGeneral', 'Courier', monospace, 'Noto Color Emoji';
// unified palette // unified palette
// try to use these colors when possible // try to use these colors when possible

12
res/themes/light/css/_light.scss
View file

@ -1,8 +1,10 @@
// XXX: check this? /* Nunito and Inter lacks combining diacritics, so these will fall through
/* Nunito lacks combining diacritics, so these will fall through to the next font. Helevetica's diacritics sometimes do not combine
to the next font. Helevetica's diacritics however do not combine
nicely (on OSX, at least) and result in a huge horizontal mess. nicely (on OSX, at least) and result in a huge horizontal mess.
Arial empirically gets it right, hence prioritising Arial here. */ Arial empirically gets it right, hence prioritising Arial here.
We also include STIXGeneral explicitly to support a wider range
of combining diacritics (Chrome fails without it, as per
https://bugs.chromium.org/p/chromium/issues/detail?id=1328898) */
/* We fall through to Twemoji for emoji rather than falling through /* We fall through to Twemoji for emoji rather than falling through
to native Emoji fonts (if any) to ensure cross-browser consistency */ to native Emoji fonts (if any) to ensure cross-browser consistency */
/* Noto Color Emoji contains digits, in fixed-width, therefore causing /* Noto Color Emoji contains digits, in fixed-width, therefore causing
@ -12,6 +14,7 @@ $font-family: 'Inter',
'Twemoji', 'Twemoji',
'Apple Color Emoji', 'Apple Color Emoji',
'Segoe UI Emoji', 'Segoe UI Emoji',
'STIXGeneral',
'Arial', 'Arial',
'Helvetica', 'Helvetica',
sans-serif, sans-serif,
@ -21,6 +24,7 @@ $monospace-font-family: 'Inconsolata',
'Twemoji', 'Twemoji',
'Apple Color Emoji', 'Apple Color Emoji',
'Segoe UI Emoji', 'Segoe UI Emoji',
'STIXGeneral',
'Courier', 'Courier',
monospace, monospace,
'Noto Color Emoji'; 'Noto Color Emoji';