From ea4000cf1e068da985461c3701d6b19ffbff8a41 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Tue, 14 Feb 2023 09:05:01 +0000 Subject: [PATCH] Fix 'Failed check: Ellipsis' on Weblate (#10144) * Fix 'Failed check: Ellipsis' on Weblate Signed-off-by: Suguru Hirahara * Fix tests Signed-off-by: Suguru Hirahara * Remove white space characters before the horizontal ellipsis from RoomPreviewBar Signed-off-by: Suguru Hirahara * yarn run i18n Signed-off-by: Suguru Hirahara * Additional change Signed-off-by: Suguru Hirahara --------- Signed-off-by: Suguru Hirahara --- .../security/CreateKeyBackupDialog.tsx | 4 +- src/components/structures/SpaceHierarchy.tsx | 4 +- src/components/structures/SpaceRoomView.tsx | 4 +- src/components/structures/auth/Login.tsx | 2 +- src/components/views/auth/LoginWithQRFlow.tsx | 2 +- src/components/views/auth/PassphraseField.tsx | 2 +- src/components/views/beacon/BeaconStatus.tsx | 2 +- .../views/dialogs/CreateSubspaceDialog.tsx | 2 +- .../views/dialogs/DeactivateAccountDialog.tsx | 2 +- src/components/views/dialogs/ExportDialog.tsx | 2 +- .../views/dialogs/IncomingSasDialog.tsx | 2 +- .../dialogs/SlidingSyncOptionsDialog.tsx | 2 +- .../views/dialogs/TextInputDialog.tsx | 2 +- .../security/RestoreKeyBackupDialog.tsx | 4 +- src/components/views/elements/AppTile.tsx | 2 +- .../views/elements/InlineSpinner.tsx | 2 +- .../views/elements/PollCreateDialog.tsx | 2 +- src/components/views/elements/Spinner.tsx | 2 +- .../views/rooms/DecryptionFailureBar.tsx | 2 +- src/components/views/rooms/EventTile.tsx | 4 +- src/components/views/rooms/RoomPreviewBar.tsx | 8 +- .../views/settings/IntegrationManager.tsx | 2 +- .../views/settings/SecureBackupPanel.tsx | 2 +- .../views/settings/UpdateCheckButton.tsx | 4 +- .../tabs/user/GeneralUserSettingsTab.tsx | 2 +- .../views/spaces/SpaceCreateMenu.tsx | 2 +- .../views/spaces/SpaceSettingsGeneralTab.tsx | 2 +- src/i18n/strings/en_EN.json | 75 +++++++++---------- src/utils/ErrorUtils.tsx | 2 +- src/utils/exportUtils/HtmlExport.tsx | 4 +- src/utils/exportUtils/PlainTextExport.ts | 6 +- .../__snapshots__/RoomView-test.tsx.snap | 2 +- .../components/structures/auth/Login-test.tsx | 18 ++--- .../structures/auth/Registration-test.tsx | 8 +- .../__snapshots__/BeaconStatus-test.tsx.snap | 2 +- .../OwnBeaconStatus-test.tsx.snap | 2 +- .../PollCreateDialog-test.tsx.snap | 6 +- .../views/messages/MBeaconBody-test.tsx | 4 +- .../__snapshots__/MPollBody-test.tsx.snap | 2 +- .../__snapshots__/MPollEndBody-test.tsx.snap | 2 +- .../views/rooms/RoomPreviewBar-test.tsx | 6 +- .../DecryptionFailureBar-test.tsx.snap | 4 +- .../FontScalingPanel-test.tsx.snap | 2 +- .../LoginWithQRFlow-test.tsx.snap | 12 +-- .../ModuleComponents-test.tsx.snap | 2 +- .../VoiceBroadcastHeader-test.tsx.snap | 2 +- .../VoiceBroadcastPlaybackBody-test.tsx.snap | 2 +- ...ceBroadcastSmallPlaybackBody-test.tsx.snap | 2 +- 48 files changed, 117 insertions(+), 120 deletions(-) diff --git a/src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx b/src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx index 654ed4bb2f..a9327f2a46 100644 --- a/src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx +++ b/src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx @@ -327,7 +327,7 @@ export default class CreateKeyBackupDialog extends React.PureComponent @@ -451,7 +451,7 @@ export default class CreateKeyBackupDialog extends React.PureComponent = ({ hierarchy, selected, set }; } - let buttonText = _t("Saving..."); + let buttonText = _t("Saving…"); if (!saving) { buttonText = selectionAllSuggested ? _t("Mark as not suggested") : _t("Mark as suggested"); } @@ -694,7 +694,7 @@ const ManageButtons: React.FC = ({ hierarchy, selected, set kind="danger_outline" disabled={disabled} > - {removing ? _t("Removing...") : _t("Remove")} + {removing ? _t("Removing…") : _t("Remove")}
"`; +exports[`PollCreateDialog renders a blank poll 1`] = `"
"`; -exports[`PollCreateDialog renders a question and some options 1`] = `"
"`; +exports[`PollCreateDialog renders a question and some options 1`] = `"
"`; -exports[`PollCreateDialog renders info from a previous event 1`] = `"
"`; +exports[`PollCreateDialog renders info from a previous event 1`] = `"
"`; diff --git a/test/components/views/messages/MBeaconBody-test.tsx b/test/components/views/messages/MBeaconBody-test.tsx index 4a114eb14c..b915c442e2 100644 --- a/test/components/views/messages/MBeaconBody-test.tsx +++ b/test/components/views/messages/MBeaconBody-test.tsx @@ -120,7 +120,7 @@ describe("", () => { ); makeRoomWithStateEvents([beaconInfoEvent], { roomId, mockClient }); const component = getComponent({ mxEvent: beaconInfoEvent }); - expect(component.text()).toEqual("Loading live location..."); + expect(component.text()).toEqual("Loading live location…"); }); it("does not open maximised map when on click when beacon is stopped", () => { @@ -227,7 +227,7 @@ describe("", () => { makeRoomWithStateEvents([aliceBeaconInfo], { roomId, mockClient }); const component = getComponent({ mxEvent: aliceBeaconInfo }); - expect(component.text()).toEqual("Loading live location..."); + expect(component.text()).toEqual("Loading live location…"); }); it("does nothing on click when a beacon has no location", () => { diff --git a/test/components/views/messages/__snapshots__/MPollBody-test.tsx.snap b/test/components/views/messages/__snapshots__/MPollBody-test.tsx.snap index 3bce56a540..c27f984101 100644 --- a/test/components/views/messages/__snapshots__/MPollBody-test.tsx.snap +++ b/test/components/views/messages/__snapshots__/MPollBody-test.tsx.snap @@ -465,7 +465,7 @@ exports[`MPollBody renders a finished poll with no votes 1`] = ` `; -exports[`MPollBody renders a loader while responses are still loading 1`] = `"Based on 4 votes
"`; +exports[`MPollBody renders a loader while responses are still loading 1`] = `"Based on 4 votes
"`; exports[`MPollBody renders a poll that I have not voted in 1`] = `
diff --git a/test/components/views/messages/__snapshots__/MPollEndBody-test.tsx.snap b/test/components/views/messages/__snapshots__/MPollEndBody-test.tsx.snap index 5da6c98349..e98ec1f4fc 100644 --- a/test/components/views/messages/__snapshots__/MPollEndBody-test.tsx.snap +++ b/test/components/views/messages/__snapshots__/MPollEndBody-test.tsx.snap @@ -95,7 +95,7 @@ exports[` when poll start event exists in current timeline rende class="mx_Spinner" >
", () => { const component = getComponent({ joining: true }); expect(isSpinnerRendered(component)).toBeTruthy(); - expect(getMessage(component)?.textContent).toEqual("Joining …"); + expect(getMessage(component)?.textContent).toEqual("Joining…"); }); it("renders rejecting message", () => { const component = getComponent({ rejecting: true }); expect(isSpinnerRendered(component)).toBeTruthy(); - expect(getMessage(component)?.textContent).toEqual("Rejecting invite …"); + expect(getMessage(component)?.textContent).toEqual("Rejecting invite…"); }); it("renders loading message", () => { const component = getComponent({ loading: true }); expect(isSpinnerRendered(component)).toBeTruthy(); - expect(getMessage(component)?.textContent).toEqual("Loading …"); + expect(getMessage(component)?.textContent).toEqual("Loading…"); }); it("renders not logged in message", () => { diff --git a/test/components/views/rooms/__snapshots__/DecryptionFailureBar-test.tsx.snap b/test/components/views/rooms/__snapshots__/DecryptionFailureBar-test.tsx.snap index bb21174a30..76adfef8b5 100644 --- a/test/components/views/rooms/__snapshots__/DecryptionFailureBar-test.tsx.snap +++ b/test/components/views/rooms/__snapshots__/DecryptionFailureBar-test.tsx.snap @@ -35,7 +35,7 @@ exports[` Displays a loading spinner 1`] = ` class="mx_Spinner" >
Displays a loading spinner 1`] = `
- Decrypting messages... + Decrypting messages…
renders spinner while connecting 1`] = ` class="mx_Spinner" >
renders spinner while connecting 1`] = ` />

- Connecting... + Connecting…

@@ -756,7 +756,7 @@ exports[` renders spinner while loading 1`] = ` class="mx_Spinner" >
renders spinner while signing in 1`] = ` class="mx_Spinner" >
renders spinner while verifying 1`] = ` class="mx_Spinner" >
renders spinner whilst QR generating 1`] = ` class="mx_Spinner" >
when rendering a buffering broadcas class="mx_Spinner" >