PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix possible uncaught exception for getUrlPreview which would cause 0 url previews if one url was faulty

Browse source
This commit is contained in:
Michael Telatynski 2021-07-15 12:10:01 +01:00
parent 1eaf6dd4ed
commit e9d56d4f13
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/components/views/rooms/LinkPreviewGroup.tsx
View file

@ -40,10 +40,12 @@ const LinkPreviewGroup: React.FC<IProps> = ({ links, mxEvent, onCancelClick, onH
const ts = mxEvent.getTs(); const ts = mxEvent.getTs();
const previews = useAsyncMemo<[string, IPreviewUrlResponse][]>(async () => { const previews = useAsyncMemo<[string, IPreviewUrlResponse][]>(async () => {
return Promise.all<[string, IPreviewUrlResponse] | void>(links.map(link => { return Promise.all<[string, IPreviewUrlResponse] | void>(links.map(async link => {
return cli.getUrlPreview(link, ts).then(preview => [link, preview], error => { try {
return [link, await cli.getUrlPreview(link, ts)];
} catch (error) {
console.error("Failed to get URL preview: " + error); console.error("Failed to get URL preview: " + error);
}); }
})).then(a => a.filter(Boolean)) as Promise<[string, IPreviewUrlResponse][]>; })).then(a => a.filter(Boolean)) as Promise<[string, IPreviewUrlResponse][]>;
}, [links, ts], []); }, [links, ts], []);