PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #2846 from matrix-org/bwindels/atbottomfix

Browse source 
round scrollTop upwards to prevent never detecting bottom
This commit is contained in:
Bruno Windels 2019-03-29 15:57:24 +00:00 committed by GitHub
commit e7852ad1b4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/components/structures/ScrollPanel.js
View file

@ -222,7 +222,10 @@ module.exports = React.createClass({
// whether it will stay that way when the children update. // whether it will stay that way when the children update.
isAtBottom: function() { isAtBottom: function() {
const sn = this._getScrollNode(); const sn = this._getScrollNode();
return sn.scrollTop === sn.scrollHeight - sn.clientHeight; // fractional values for scrollTop happen on certain browsers/platforms
// when scrolled all the way down. E.g. Chrome 72 on debian.
// so ceil everything upwards to make sure it aligns.
return Math.ceil(sn.scrollTop) === Math.ceil(sn.scrollHeight - sn.clientHeight);
}, },
// returns the vertical height in the given direction that can be removed from // returns the vertical height in the given direction that can be removed from