Update tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2023-09-11 17:55:32 +01:00
parent 0a36af7cc0
commit e54dd60381
No known key found for this signature in database
GPG key ID: A2B008A5F49F5D0D
2 changed files with 26 additions and 26 deletions

View file

@ -18,7 +18,7 @@ import React from "react";
import userEvent from "@testing-library/user-event"; import userEvent from "@testing-library/user-event";
import { CallType, MatrixCall } from "matrix-js-sdk/src/webrtc/call"; import { CallType, MatrixCall } from "matrix-js-sdk/src/webrtc/call";
import { EventType, JoinRule, MatrixClient, MatrixEvent, PendingEventOrdering, Room } from "matrix-js-sdk/src/matrix"; import { EventType, JoinRule, MatrixClient, MatrixEvent, PendingEventOrdering, Room } from "matrix-js-sdk/src/matrix";
import { getAllByTitle, getByLabelText, getByText, getByTitle, render, screen, waitFor } from "@testing-library/react"; import { getAllByLabelText, getByLabelText, getByText, render, screen, waitFor } from "@testing-library/react";
import { mkEvent, stubClient, withClientContextRenderOptions } from "../../../test-utils"; import { mkEvent, stubClient, withClientContextRenderOptions } from "../../../test-utils";
import RoomHeader from "../../../../src/components/views/rooms/RoomHeader"; import RoomHeader from "../../../../src/components/views/rooms/RoomHeader";
@ -195,7 +195,7 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
await userEvent.click(getByTitle(container, "Threads")); await userEvent.click(getByLabelText(container, "Threads"));
expect(setCardSpy).toHaveBeenCalledWith({ phase: RightPanelPhases.ThreadPanel }); expect(setCardSpy).toHaveBeenCalledWith({ phase: RightPanelPhases.ThreadPanel });
}); });
@ -205,7 +205,7 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
await userEvent.click(getByTitle(container, "Notifications")); await userEvent.click(getByLabelText(container, "Notifications"));
expect(setCardSpy).toHaveBeenCalledWith({ phase: RightPanelPhases.NotificationPanel }); expect(setCardSpy).toHaveBeenCalledWith({ phase: RightPanelPhases.NotificationPanel });
}); });
@ -216,7 +216,7 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
for (const button of getAllByTitle(container, "There's no one here to call")) { for (const button of getAllByLabelText(container, "There's no one here to call")) {
expect(button).toBeDisabled(); expect(button).toBeDisabled();
} }
}); });
@ -227,8 +227,8 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
const voiceButton = getByTitle(container, "Voice call"); const voiceButton = getByLabelText(container, "Voice call");
const videoButton = getByTitle(container, "Video call"); const videoButton = getByLabelText(container, "Video call");
expect(voiceButton).not.toBeDisabled(); expect(voiceButton).not.toBeDisabled();
expect(videoButton).not.toBeDisabled(); expect(videoButton).not.toBeDisabled();
@ -251,7 +251,7 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
for (const button of getAllByTitle(container, "Ongoing call")) { for (const button of getAllByLabelText(container, "Ongoing call")) {
expect(button).toBeDisabled(); expect(button).toBeDisabled();
} }
}); });
@ -264,8 +264,8 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
expect(getByTitle(container, "Voice call")).not.toBeDisabled(); expect(getByLabelText(container, "Voice call")).not.toBeDisabled();
expect(getByTitle(container, "Video call")).not.toBeDisabled(); expect(getByLabelText(container, "Video call")).not.toBeDisabled();
}); });
it("disable calls in large rooms by default", () => { it("disable calls in large rooms by default", () => {
@ -275,8 +275,8 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
expect(getByTitle(container, "You do not have permission to start voice calls")).toBeDisabled(); expect(getByLabelText(container, "You do not have permission to start voice calls")).toBeDisabled();
expect(getByTitle(container, "You do not have permission to start video calls")).toBeDisabled(); expect(getByLabelText(container, "You do not have permission to start video calls")).toBeDisabled();
}); });
}); });
@ -297,12 +297,12 @@ describe("RoomHeader", () => {
expect(screen.queryByTitle("Voice call")).toBeNull(); expect(screen.queryByTitle("Voice call")).toBeNull();
const videoCallButton = getByTitle(container, "Video call"); const videoCallButton = getByLabelText(container, "Video call");
expect(videoCallButton).not.toBeDisabled(); expect(videoCallButton).not.toBeDisabled();
const dispatcherSpy = jest.spyOn(dispatcher, "dispatch"); const dispatcherSpy = jest.spyOn(dispatcher, "dispatch");
await userEvent.click(getByTitle(container, "Video call")); await userEvent.click(getByLabelText(container, "Video call"));
expect(dispatcherSpy).toHaveBeenCalledWith(expect.objectContaining({ view_call: true })); expect(dispatcherSpy).toHaveBeenCalledWith(expect.objectContaining({ view_call: true }));
}); });
@ -318,7 +318,7 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
expect(getByTitle(container, "Ongoing call")).toBeDisabled(); expect(getByLabelText(container, "Ongoing call")).toBeDisabled();
}); });
it("disables calling if there's a jitsi call", () => { it("disables calling if there's a jitsi call", () => {
@ -331,7 +331,7 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
for (const button of getAllByTitle(container, "Ongoing call")) { for (const button of getAllByLabelText(container, "Ongoing call")) {
expect(button).toBeDisabled(); expect(button).toBeDisabled();
} }
}); });
@ -342,7 +342,7 @@ describe("RoomHeader", () => {
<RoomHeader room={room} />, <RoomHeader room={room} />,
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
for (const button of getAllByTitle(container, "There's no one here to call")) { for (const button of getAllByLabelText(container, "There's no one here to call")) {
expect(button).toBeDisabled(); expect(button).toBeDisabled();
} }
}); });
@ -354,8 +354,8 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
const voiceButton = getByTitle(container, "Voice call"); const voiceButton = getByLabelText(container, "Voice call");
const videoButton = getByTitle(container, "Video call"); const videoButton = getByLabelText(container, "Video call");
expect(voiceButton).not.toBeDisabled(); expect(voiceButton).not.toBeDisabled();
expect(videoButton).not.toBeDisabled(); expect(videoButton).not.toBeDisabled();
@ -380,8 +380,8 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
const voiceButton = getByTitle(container, "Voice call"); const voiceButton = getByLabelText(container, "Voice call");
const videoButton = getByTitle(container, "Video call"); const videoButton = getByLabelText(container, "Video call");
expect(voiceButton).not.toBeDisabled(); expect(voiceButton).not.toBeDisabled();
expect(videoButton).not.toBeDisabled(); expect(videoButton).not.toBeDisabled();
@ -407,8 +407,8 @@ describe("RoomHeader", () => {
withClientContextRenderOptions(MatrixClientPeg.get()!), withClientContextRenderOptions(MatrixClientPeg.get()!),
); );
const voiceButton = getByTitle(container, "Voice call"); const voiceButton = getByLabelText(container, "Voice call");
const videoButton = getByTitle(container, "Video call"); const videoButton = getByLabelText(container, "Video call");
expect(voiceButton).not.toBeDisabled(); expect(voiceButton).not.toBeDisabled();
expect(videoButton).not.toBeDisabled(); expect(videoButton).not.toBeDisabled();

View file

@ -35,36 +35,36 @@ exports[`RoomHeader does not show the face pile for DMs 1`] = `
style="--mx-flex-display: flex; --mx-flex-direction: row; --mx-flex-align: center; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-2x);" style="--mx-flex-display: flex; --mx-flex-direction: row; --mx-flex-align: center; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-2x);"
> >
<button <button
aria-label="There's no one here to call"
class="_icon-button_1k9cw_17" class="_icon-button_1k9cw_17"
data-state="closed" data-state="closed"
disabled="" disabled=""
style="--cpd-icon-button-size: 32px;" style="--cpd-icon-button-size: 32px;"
title="There's no one here to call"
> >
<div /> <div />
</button> </button>
<button <button
aria-label="There's no one here to call"
class="_icon-button_1k9cw_17" class="_icon-button_1k9cw_17"
data-state="closed" data-state="closed"
disabled="" disabled=""
style="--cpd-icon-button-size: 32px;" style="--cpd-icon-button-size: 32px;"
title="There's no one here to call"
> >
<div /> <div />
</button> </button>
<button <button
aria-label="Threads"
class="_icon-button_1k9cw_17" class="_icon-button_1k9cw_17"
data-state="closed" data-state="closed"
style="--cpd-icon-button-size: 32px;" style="--cpd-icon-button-size: 32px;"
title="Threads"
> >
<div /> <div />
</button> </button>
<button <button
aria-label="Notifications"
class="_icon-button_1k9cw_17" class="_icon-button_1k9cw_17"
data-state="closed" data-state="closed"
style="--cpd-icon-button-size: 32px;" style="--cpd-icon-button-size: 32px;"
title="Notifications"
> >
<div /> <div />
</button> </button>