PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Unbreak in-app permalink tooltips (#9087)

Browse source 
* Unbreak in-app permalink tooltips

Fixes: vector-im/element-web#22874
Signed-off-by: Johannes Marbach <johannesm@element.io>

* Appease the linter

* Fix the tests
This commit is contained in:
Johannes Marbach 2022-07-26 13:04:00 +02:00 committed by GitHub
parent 60696d78ca
commit e28fd8651e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/utils/tooltipify.tsx
View file

@ -53,11 +53,11 @@ export function tooltipifyLinks(rootNodes: ArrayLike<Element>, ignoredNodes: Ele
const href = node.getAttribute("href");
const tooltip = <LinkWithTooltip tooltip={new URL(href, window.location.href).toString()}>
<span dangerouslySetInnerHTML={{ __html: node.outerHTML }} />
{ node.innerHTML }
</LinkWithTooltip>;
ReactDOM.render(tooltip, container);
node.parentNode.replaceChild(container, node);
node.replaceChildren(container);
containers.push(container);
tooltipified = true;
}

5
test/utils/tooltipify-test.tsx
View file

@ -41,9 +41,10 @@ describe('tooltipify', () => {
const containers: Element[] = [];
tooltipifyLinks([root], [], containers);
expect(containers).toHaveLength(1);
const anchor = root.querySelector(".mx_TextWithTooltip_target a");
const anchor = root.querySelector("a");
expect(anchor?.getAttribute("href")).toEqual("/foo");
expect(anchor?.innerHTML).toEqual("click");
const tooltip = anchor.querySelector(".mx_TextWithTooltip_target");
expect(tooltip).toBeDefined();
});
it('ignores node', () => {