PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix click behavior of notification badges on spaces (#8627)

Browse source 
* Fix click behavior of notification badges on spaces

* Fix import
This commit is contained in:
Robin 2022-05-17 10:28:19 -04:00 committed by GitHub
parent d717d06ce5
commit e099ebd9ec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/components/views/spaces/SpaceTreeLevel.tsx
View file

@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
import React, { ComponentProps, ComponentType, createRef, InputHTMLAttributes, LegacyRef } from "react"; import React, { MouseEvent, ComponentProps, ComponentType, createRef, InputHTMLAttributes, LegacyRef } from "react";
import classNames from "classnames"; import classNames from "classnames";
import { Room, RoomEvent } from "matrix-js-sdk/src/models/room"; import { Room, RoomEvent } from "matrix-js-sdk/src/models/room";
import { DraggableProvidedDragHandleProps } from "react-beautiful-dnd"; import { DraggableProvidedDragHandleProps } from "react-beautiful-dnd";
@ -84,9 +84,15 @@ export const SpaceButton: React.FC<IButtonProps> = ({
ariaLabel = _t("Jump to first invite."); ariaLabel = _t("Jump to first invite.");
} }
const jumpToNotification = (ev: MouseEvent) => {
ev.stopPropagation();
ev.preventDefault();
SpaceStore.instance.setActiveRoomInSpace(spaceKey ?? space.roomId);
};
notifBadge = <div className="mx_SpacePanel_badgeContainer"> notifBadge = <div className="mx_SpacePanel_badgeContainer">
<NotificationBadge <NotificationBadge
onClick={() => SpaceStore.instance.setActiveRoomInSpace(spaceKey ?? space.roomId)} onClick={jumpToNotification}
forceCount={false} forceCount={false}
notification={notificationState} notification={notificationState}
aria-label={ariaLabel} aria-label={ariaLabel}