PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Disable two flaky Percy tests - see #25283 and #24881 (#10878)

Browse source
This commit is contained in:
Andy Balaam 2023-05-12 10:56:32 +01:00 committed by GitHub
parent 415fcde5e8
commit dbf73f725f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cypress/e2e/permalinks/permalinks.spec.ts
View file

@ -131,7 +131,8 @@ describe("permalinks", () => {
cy.get(".mx_NewRoomIntro").invoke("remove");
cy.get(".mx_GenericEventListSummary").invoke("remove");
const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
// Disabled because flaky - see https://github.com/vector-im/element-web/issues/25283
//const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
//cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
});
});

9
cypress/e2e/timeline/timeline.spec.ts
View file

@ -583,7 +583,7 @@ describe("Timeline", () => {
cy.get(".mx_RoomView_body .mx_EventTile_info .mx_MessageTimestamp").click();
// Exclude timestamp and read marker from snapshot
const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
//const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }";
// should not add inline start padding to a hidden event line on IRC layout
cy.setSettingValue("layout", null, SettingLevel.DEVICE, Layout.IRC);
@ -604,9 +604,10 @@ describe("Timeline", () => {
// calc(var(--EventTile_group_line-spacing-inline-start) + 20px) = 64 + 20 = 84px
.should("have.css", "padding-inline-start", "84px");
cy.get(".mx_MainSplit").percySnapshotElement("Hidden event line with padding on modern layout", {
percyCSS,
});
// Disabled because flaky - see https://github.com/vector-im/element-web/issues/24881
//cy.get(".mx_MainSplit").percySnapshotElement("Hidden event line with padding on modern layout", {
// percyCSS,
//});
});
it("should click view source event toggle", () => {