PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Pass false to onFinished from BaseDialog

Browse source 
Everywhere else, onFinished takes a boolean indicating whether the
dialog was confirmed on cancelled, and had function that were
expecting this variable and getting undefined.
This commit is contained in:
David Baker 2018-04-27 11:19:14 +01:00
parent f70096b8fa
commit db1401f484
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/views/dialogs/BaseDialog.js
View file

@ -36,6 +36,9 @@ export default React.createClass({
propTypes: { propTypes: {
// onFinished callback to call when Escape is pressed // onFinished callback to call when Escape is pressed
// Take a boolean which is true is the dialog was dismissed
// with a positive / confirm action or false if it was
// cancelled (from BaseDialog, this is always false).
onFinished: PropTypes.func.isRequired, onFinished: PropTypes.func.isRequired,
// called when a key is pressed // called when a key is pressed
@ -77,12 +80,12 @@ export default React.createClass({
if (e.keyCode === KeyCode.ESCAPE) { if (e.keyCode === KeyCode.ESCAPE) {
e.stopPropagation(); e.stopPropagation();
e.preventDefault(); e.preventDefault();
this.props.onFinished(); this.props.onFinished(false);
} }
}, },
_onCancelClick: function(e) { _onCancelClick: function(e) {
this.props.onFinished(); this.props.onFinished(false);
}, },
render: function() { render: function() {