Merge pull request #3586 from matrix-org/dbkr/fix_rooms_missing_from_search_2

Fix bug where rooms would not appear when filtering
This commit is contained in:
David Baker 2019-11-01 10:12:10 +00:00 committed by GitHub
commit dabdf78e32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -67,6 +67,9 @@ const RoomSubList = createReactClass({
// some values to get LazyRenderList starting // some values to get LazyRenderList starting
scrollerHeight: 800, scrollerHeight: 800,
scrollTop: 0, scrollTop: 0,
// React 16's getDerivedStateFromProps(props, state) doesn't give the previous props so
// we have to store the length of the list here so we can see if it's changed or not...
listLength: null,
}; };
}, },
@ -79,11 +82,20 @@ const RoomSubList = createReactClass({
}; };
}, },
componentWillMount: function() { componentDidMount: function() {
this._headerButton = createRef(); this._headerButton = createRef();
this.dispatcherRef = dis.register(this.onAction); this.dispatcherRef = dis.register(this.onAction);
}, },
statics: {
getDerivedStateFromProps: function(props, state) {
return {
listLength: props.list.length,
scrollTop: props.list.length === state.listLength ? state.scrollTop : 0,
};
},
},
componentWillUnmount: function() { componentWillUnmount: function() {
dis.unregister(this.dispatcherRef); dis.unregister(this.dispatcherRef);
}, },