PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix a crash when removing persistent widgets (updated) (#10099)

Browse source 
* Fix a crash when removing persistent widgets

When a persistent widget is removed, multiple calls to updateShowWidgetInPip happen in succession as each of the widget stores emit updates. But by depending on this.state.persistentWidgetId at the time of the call rather than passing an update function to setState, this had the effect that the removal of the widget could be reverted in the component's state, and so it could end up passing the ID of a removed widget to WidgetPip.

* Re-public updateShowWidgetInPip so we don't change the interface

---------

Co-authored-by: Robin Townsend <robin@robin.town>
This commit is contained in:
Andy Balaam 2023-02-07 11:14:19 +00:00 committed by GitHub
parent 14e5ffbd31
commit da2471ffbd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/components/structures/PipContainer.tsx
View file

@ -192,10 +192,7 @@ class PipContainerInner extends React.Component<IProps, IState> {
}; };
private onWidgetPersistence = (): void => { private onWidgetPersistence = (): void => {
this.updateShowWidgetInPip( this.updateShowWidgetInPip();
ActiveWidgetStore.instance.getPersistentWidgetId(),
ActiveWidgetStore.instance.getPersistentRoomId(),
);
}; };
private onWidgetDockChanges = (): void => { private onWidgetDockChanges = (): void => {
@ -234,11 +231,10 @@ class PipContainerInner extends React.Component<IProps, IState> {
} }
}; };
// Accepts a persistentWidgetId to be able to skip awaiting the setState for persistentWidgetId public updateShowWidgetInPip(): void {
public updateShowWidgetInPip( const persistentWidgetId = ActiveWidgetStore.instance.getPersistentWidgetId();
persistentWidgetId = this.state.persistentWidgetId, const persistentRoomId = ActiveWidgetStore.instance.getPersistentRoomId();
persistentRoomId = this.state.persistentRoomId,
): void {
let fromAnotherRoom = false; let fromAnotherRoom = false;
let notDocked = false; let notDocked = false;
// Sanity check the room - the widget may have been destroyed between render cycles, and // Sanity check the room - the widget may have been destroyed between render cycles, and