PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

PR feedback

Browse source
This commit is contained in:
David Baker 2016-11-08 11:43:24 +00:00
parent d44adcb7a9
commit d871ca2b24
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/BasePlatform.js
View file

@ -71,6 +71,6 @@ export default class BasePlatform {
* the current version of the application.
*/
getAppVersion() {
return q();
throw new Error("getAppVersion not implemented!");
}
}

5
src/components/structures/UserSettings.js
View file

@ -36,7 +36,6 @@ module.exports = React.createClass({
displayName: 'UserSettings',
propTypes: {
version: React.PropTypes.string,
onClose: React.PropTypes.func,
// The brand string given when creating email pushers
brand: React.PropTypes.string,
@ -66,8 +65,11 @@ module.exports = React.createClass({
},
componentWillMount: function() {
this._unmounted = false;
if (PlatformPeg.get()) {
PlatformPeg.get().getAppVersion().done((appVersion) => {
if (this._unmounted) return;
this.setState({
vectorVersion: appVersion,
});
@ -90,6 +92,7 @@ module.exports = React.createClass({
},
componentWillUnmount: function() {
this._unmounted = true;
dis.dispatch({
action: 'ui_opacity',
sideOpacity: 1.0,