PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix joining rooms by typing the alias

Browse source 
Fixes regression introduced by https://github.com/vector-im/vector-web/pull/1680
This commit is contained in:
David Baker 2016-06-23 10:11:46 +01:00
parent c12839dc7b
commit d45e44d01c
1 changed files with 36 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

62
src/components/structures/RoomDirectory.js
View file

@ -126,38 +126,48 @@ module.exports = React.createClass({
}); });
}, },
showRoom: function(room, ev) { onRoomClicked: function(room, ev) {
if (ev.shiftKey) { if (ev.shiftKey) {
ev.preventDefault(); ev.preventDefault();
this.removeFromDirectory(room); this.removeFromDirectory(room);
return; } else {
this.showRoom(room);
} }
},
showRoomAlias: function(alias) {
this.showRoom(null, alias);
},
showRoom: function(room, room_alias) {
var oob_data = {}; var oob_data = {};
if (MatrixClientPeg.get().isGuest()) { var payload = {action: 'view_room'};
if (!room.world_readable && !room.guest_can_join) { if (room) {
var NeedToRegisterDialog = sdk.getComponent("dialogs.NeedToRegisterDialog"); // Don't let the user view a room they won't be able to either
Modal.createDialog(NeedToRegisterDialog, { // peek or join: fail earlier so they don't have to click back
title: "Failed to join the room", // to the directory.
description: "This room is inaccessible to guests. You may be able to join if you register." if (MatrixClientPeg.get().isGuest()) {
}); if (!room.world_readable && !room.guest_can_join) {
return; var NeedToRegisterDialog = sdk.getComponent("dialogs.NeedToRegisterDialog");
Modal.createDialog(NeedToRegisterDialog, {
title: "Failed to join the room",
description: "This room is inaccessible to guests. You may be able to join if you register."
});
return;
}
} }
if (!room_alias) {
room_alias = get_display_alias_for_room(room);
}
payload.oob_data = {
avatarUrl: room.avatar_url,
// XXX: This logic is duplicated from the JS SDK which
// would normally decide what the name is.
name: room.name || room_alias || "Unnamed room",
};
} }
var room_alias = get_display_alias_for_room(room);
oob_data = {
avatarUrl: room.avatar_url,
// XXX: This logic is duplicated from the JS SDK which
// would normally decide what the name is.
name: room.name || room_alias || "Unnamed room",
};
var payload = {
oob_data: oob_data,
action: 'view_room',
};
// It's not really possible to join Matrix rooms by ID because the HS has no way to know // It's not really possible to join Matrix rooms by ID because the HS has no way to know
// which servers to start querying. However, there's no other way to join rooms in // which servers to start querying. However, there's no other way to join rooms in
// this list without aliases at present, so if roomAlias isn't set here we have no // this list without aliases at present, so if roomAlias isn't set here we have no
@ -213,7 +223,7 @@ module.exports = React.createClass({
rows.unshift( rows.unshift(
<tr key={ rooms[i].room_id } <tr key={ rooms[i].room_id }
onClick={self.showRoom.bind(null, rooms[i])} onClick={self.onRoomClicked.bind(self, rooms[i])}
// cancel onMouseDown otherwise shift-clicking highlights text // cancel onMouseDown otherwise shift-clicking highlights text
onMouseDown={(ev) => {ev.preventDefault();}} onMouseDown={(ev) => {ev.preventDefault();}}
> >
@ -245,7 +255,7 @@ module.exports = React.createClass({
this.forceUpdate(); this.forceUpdate();
this.setState({ roomAlias : this.refs.roomAlias.value }) this.setState({ roomAlias : this.refs.roomAlias.value })
if (ev.key == "Enter") { if (ev.key == "Enter") {
this.showRoom(null, this.refs.roomAlias.value); this.showRoomAlias(this.refs.roomAlias.value);
} }
}, },