From d4578783ef3b3ae6a788b2059f57d4b23381fea2 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Wed, 13 Jun 2018 18:46:02 +0100
Subject: [PATCH] apply pr review feedback fix copyright headers fix user
 settings link accessibility fix typo and add noopener

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
---
 src/components/structures/ContextualMenu.js | 2 +-
 src/components/structures/UserSettings.js   | 4 ++--
 src/components/views/dialogs/ShareDialog.js | 9 +++++----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/components/structures/ContextualMenu.js b/src/components/structures/ContextualMenu.js
index d6a11ca974..12603c1b45 100644
--- a/src/components/structures/ContextualMenu.js
+++ b/src/components/structures/ContextualMenu.js
@@ -1,6 +1,6 @@
 /*
 Copyright 2015, 2016 OpenMarket Ltd
-Copyright 2018 Vector Creations Ltd
+Copyright 2018 New Vector Ltd
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
diff --git a/src/components/structures/UserSettings.js b/src/components/structures/UserSettings.js
index 8511010ed6..25ca70056b 100644
--- a/src/components/structures/UserSettings.js
+++ b/src/components/structures/UserSettings.js
@@ -1304,9 +1304,9 @@ module.exports = React.createClass({
                 <div className="mx_UserSettings_section">
                     <div className="mx_UserSettings_advanced">
                         { _t("Logged in as:") + ' ' }
-                        <span onClick={this.onSelfShareClick} className="mx_UserSettings_link">
+                        <a onClick={this.onSelfShareClick} className="mx_UserSettings_link">
                             { this._me }
-                        </span>
+                        </a>
                     </div>
                     <div className="mx_UserSettings_advanced">
                         { _t('Access Token:') + ' ' }
diff --git a/src/components/views/dialogs/ShareDialog.js b/src/components/views/dialogs/ShareDialog.js
index a88052ee6d..e68922d35a 100644
--- a/src/components/views/dialogs/ShareDialog.js
+++ b/src/components/views/dialogs/ShareDialog.js
@@ -1,5 +1,5 @@
 /*
-Copyright 2018 Vector Creations Ltd
+Copyright 2018 New Vector Ltd
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -37,7 +37,7 @@ const socials = [
         img: 'img/social/',
         url: (url) => `https://plus.google.com/share?url=${url}`,
     },*/ {
-        name: 'Linked In',
+        name: 'LinkedIn',
         img: 'img/social/linkedin.png',
         url: (url) => `https://www.linkedin.com/shareArticle?mini=true&url=${url}`,
     }, {
@@ -193,13 +193,14 @@ export default class ShareDialog extends React.Component {
                         <h3>Social</h3>
                         <div className="mx_ShareDialog_social_container">
                             {
-                                socials.map((social) => <a target="_blank"
+                                socials.map((social) => <a rel="noopener"
+                                                           target="_blank"
                                                            key={social.name}
                                                            name={social.name}
                                                            href={social.url(encodedUrl)}
                                                            className="mx_ShareDialog_social_icon"
                                 >
-                                    <img src={social.img} height={64} width={64} />
+                                    <img src={social.img} alt={social.name} height={64} width={64} />
                                 </a>)
                             }
                         </div>