Enable strictPropertyInitialization (#11203)

.github/workflows/static_analysis.yaml

@@ -43,46 +43,6 @@ jobs:
             - name: Typecheck (release mode)
               run: "yarn run lint:types"
 
-    tsc-strict:
-        name: Typescript Strict Error Checker
-        if: github.event_name == 'pull_request'
-        runs-on: ubuntu-latest
-        permissions:
-            pull-requests: read
-            checks: write
-        steps:
-            - uses: actions/checkout@v3
-              with:
-                  ref: ${{ github.event.pull_request.head.sha }}
-
-            - name: Install Deps
-              run: "scripts/ci/layered.sh"
-
-            - name: Get diff lines
-              id: diff
-              uses: Equip-Collaboration/diff-line-numbers@e752977e2cb4207d671bb9e4dad18c07c1b73d52 # v1.1.0
-              with:
-                  include: '["\\.tsx?$"]'
-
-            - name: Detecting files changed
-              id: files
-              uses: futuratrepadeira/changed-files@0239328a3a6268aad16af7c3e4efc78e32d6c0f0 # v4.0.1
-              with:
-                  repo-token: ${{ secrets.GITHUB_TOKEN }}
-                  pattern: '^.*\.tsx?$'
-
-            - uses: t3chguy/typescript-check-action@main
-              with:
-                  repo-token: ${{ secrets.GITHUB_TOKEN }}
-                  use-check: false
-                  check-fail-mode: added
-                  output-behaviour: annotate
-                  ts-extra-args: "--strict --noImplicitAny"
-                  files-changed: ${{ steps.files.outputs.files_updated }}
-                  files-added: ${{ steps.files.outputs.files_created }}
-                  files-deleted: ${{ steps.files.outputs.files_deleted }}
-                  line-numbers: ${{ steps.diff.outputs.lineNumbers }}
-
     i18n_lint:
         name: "i18n Check"
         uses: matrix-org/matrix-react-sdk/.github/workflows/i18n_check.yml@develop

src/Lifecycle.ts

@@ -497,7 +497,7 @@ export async function restoreFromLocalStorage(opts?: { ignoreGuest?: boolean }):
     }
 }
 
-async function handleLoadSessionFailure(e: Error): Promise<boolean> {
+async function handleLoadSessionFailure(e: unknown): Promise<boolean> {
     logger.error("Unable to load session", e);
 
     const modal = Modal.createDialog(SessionRestoreErrorDialog, {

src/PosthogAnalytics.ts

@@ -324,7 +324,7 @@ export class PosthogAnalytics {
             } catch (e) {
                 // The above could fail due to network requests, but not essential to starting the application,
                 // so swallow it.
-                logger.log("Unable to identify user for tracking" + e.toString());
+                logger.log("Unable to identify user for tracking", e);
             }
         }
     }

src/components/views/auth/CaptchaForm.tsx

@@ -117,7 +117,7 @@ export default class CaptchaForm extends React.Component<ICaptchaFormProps, ICap
             });
         } catch (e) {
             this.setState({
-                errorText: e.toString(),
+                errorText: e instanceof Error ? e.message : String(e),
             });
         }
     }

src/components/views/auth/InteractiveAuthEntryComponents.tsx

@@ -647,7 +647,7 @@ export class MsisdnAuthEntry extends React.Component<IMsisdnAuthEntryProps, IMsi
                 });
             }
         } catch (e) {
-            this.props.fail(e);
+            this.props.fail(e instanceof Error ? e : new Error("Failed to submit msisdn token"));
             logger.log("Failed to submit msisdn token");
         }
     };

src/components/views/beacon/BeaconViewDialog.tsx

@@ -112,7 +112,7 @@ const BeaconViewDialog: React.FC<IProps> = ({ initialFocusedBeacon, roomId, matr
 
     const { bounds, centerGeoUri } = useMapPosition(liveBeacons, focusedBeaconState);
 
-    const [mapDisplayError, setMapDisplayError] = useState<Error>();
+    const [mapDisplayError, setMapDisplayError] = useState<unknown>();
 
     // automatically open the sidebar if there is no map to see
     useEffect(() => {
@@ -156,7 +156,9 @@ const BeaconViewDialog: React.FC<IProps> = ({ initialFocusedBeacon, roomId, matr
                         )}
                     </Map>
                 )}
-                {mapDisplayError && <MapError error={mapDisplayError.message as LocationShareError} isMinimised />}
+                {mapDisplayError instanceof Error && (
+                    <MapError error={mapDisplayError.message as LocationShareError} isMinimised />
+                )}
                 {!centerGeoUri && !mapDisplayError && (
                     <MapFallback data-testid="beacon-view-dialog-map-fallback" className="mx_BeaconViewDialog_map">
                         <span className="mx_BeaconViewDialog_mapFallbackMessage">{_t("No live locations")}</span>

src/components/views/dialogs/AddExistingToSpaceDialog.tsx

@@ -154,7 +154,7 @@ export const AddExistingToSpace: React.FC<IAddExistingToSpaceProps> = ({
 
     const [selectedToAdd, setSelectedToAdd] = useState(new Set<Room>());
     const [progress, setProgress] = useState<number | null>(null);
-    const [error, setError] = useState<Error | null>(null);
+    const [error, setError] = useState(false);
     const [query, setQuery] = useState("");
     const lcQuery = query.toLowerCase().trim();
 
@@ -196,10 +196,10 @@ export const AddExistingToSpace: React.FC<IAddExistingToSpaceProps> = ({
     }, [visibleRooms, space, lcQuery, existingRoomsSet, existingSubspacesSet]);
 
     const addRooms = async (): Promise<void> => {
-        setError(null);
+        setError(false);
         setProgress(0);
 
-        let error: Error | undefined;
+        let error = false;
 
         for (const room of selectedToAdd) {
             const via = calculateRoomVia(room);
@@ -216,7 +216,7 @@ export const AddExistingToSpace: React.FC<IAddExistingToSpaceProps> = ({
                 setProgress((i) => (i ?? 0) + 1);
             } catch (e) {
                 logger.error("Failed to add rooms to space", e);
-                error = e;
+                error = true;
                 break;
             }
         }

src/components/views/dialogs/BugReportDialog.tsx

@@ -37,7 +37,7 @@ interface IProps {
     onFinished: (success: boolean) => void;
     initialText?: string;
     label?: string;
-    error?: Error;
+    error?: unknown;
 }
 
 interface IState {

src/components/views/dialogs/SessionRestoreErrorDialog.tsx

@@ -27,7 +27,7 @@ import BaseDialog from "./BaseDialog";
 import DialogButtons from "../elements/DialogButtons";
 
 interface IProps {
-    error: Error;
+    error: unknown;
     onFinished(clear?: boolean): void;
 }
 

src/components/views/dialogs/SlidingSyncOptionsDialog.tsx

@@ -84,8 +84,8 @@ export const SlidingSyncOptionsDialog: React.FC<{ onFinished(enabled: boolean):
             : _t("Your server lacks native support");
     }
 
-    const validProxy = withValidation<undefined, { error?: Error }>({
-        async deriveData({ value }): Promise<{ error?: Error }> {
+    const validProxy = withValidation<undefined, { error?: unknown }>({
+        async deriveData({ value }): Promise<{ error?: unknown }> {
             try {
                 await proxyHealthCheck(value!, MatrixClientPeg.safeGet().baseUrl);
                 return {};
@@ -104,7 +104,7 @@ export const SlidingSyncOptionsDialog: React.FC<{ onFinished(enabled: boolean):
                 final: true,
                 test: async (_, { error }) => !error,
                 valid: () => _t("Looks good"),
-                invalid: ({ error }) => error?.message ?? null,
+                invalid: ({ error }) => (error instanceof Error ? error.message : null),
             },
         ],
     });

src/components/views/dialogs/devtools/Event.tsx

@@ -111,7 +111,7 @@ export const EventEditor: React.FC<IEventEditorProps> = ({ fieldDefs, defaultCon
             const json = JSON.parse(content);
             await onSend(fieldData, json);
         } catch (e) {
-            return _t("Failed to send event!") + ` (${e.toString()})`;
+            return _t("Failed to send event!") + (e instanceof Error ? ` (${e.message})` : "");
         }
         return _t("Event sent!");
     };

src/components/views/dialogs/devtools/SettingExplorer.tsx

@@ -125,7 +125,7 @@ const EditSetting: React.FC<IEditSettingProps> = ({ setting, onBack }) => {
             }
             onBack();
         } catch (e) {
-            return _t("Failed to save settings.") + ` (${e.message})`;
+            return _t("Failed to save settings.") + (e instanceof Error ? ` (${e.message})` : "");
         }
     };
 

src/components/views/dialogs/security/CreateCrossSigningDialog.tsx

@@ -37,7 +37,7 @@ interface IProps {
 }
 
 interface IState {
-    error: Error | null;
+    error: boolean;
     canUploadKeysWithPasswordOnly: boolean | null;
     accountPassword: string;
 }
@@ -52,7 +52,7 @@ export default class CreateCrossSigningDialog extends React.PureComponent<IProps
         super(props);
 
         this.state = {
-            error: null,
+            error: false,
             // Does the server offer a UI auth flow with just m.login.password
             // for /keys/device_signing/upload?
             // If we have an account password in memory, let's simplify and
@@ -145,7 +145,7 @@ export default class CreateCrossSigningDialog extends React.PureComponent<IProps
 
     private bootstrapCrossSigning = async (): Promise<void> => {
         this.setState({
-            error: null,
+            error: false,
         });
 
         try {
@@ -161,7 +161,7 @@ export default class CreateCrossSigningDialog extends React.PureComponent<IProps
                 return;
             }
 
-            this.setState({ error: e });
+            this.setState({ error: true });
             logger.error("Error bootstrapping cross-signing", e);
         }
     };

src/components/views/dialogs/security/RestoreKeyBackupDialog.tsx

@@ -20,6 +20,7 @@ import { MatrixClient } from "matrix-js-sdk/src/client";
 import { IKeyBackupInfo, IKeyBackupRestoreResult } from "matrix-js-sdk/src/crypto/keybackup";
 import { ISecretStorageKeyInfo } from "matrix-js-sdk/src/crypto/api";
 import { logger } from "matrix-js-sdk/src/logger";
+import { MatrixError } from "matrix-js-sdk/src/matrix";
 
 import { MatrixClientPeg } from "../../../../MatrixClientPeg";
 import { _t } from "../../../../languageHandler";
@@ -56,9 +57,7 @@ interface IState {
     backupKeyStored: Record<string, ISecretStorageKeyInfo> | null;
     loading: boolean;
     loadError: boolean | null;
-    restoreError: {
-        errcode: string;
-    } | null;
+    restoreError: unknown | null;
     recoveryKey: string;
     recoverInfo: IKeyBackupRestoreResult | null;
     recoveryKeyValid: boolean;
@@ -343,7 +342,10 @@ export default class RestoreKeyBackupDialog extends React.PureComponent<IProps,
             title = _t("Error");
             content = _t("Unable to load backup status");
         } else if (this.state.restoreError) {
-            if (this.state.restoreError.errcode === MatrixClient.RESTORE_BACKUP_ERROR_BAD_KEY) {
+            if (
+                this.state.restoreError instanceof MatrixError &&
+                this.state.restoreError.errcode === MatrixClient.RESTORE_BACKUP_ERROR_BAD_KEY
+            ) {
                 if (this.state.restoreType === RestoreType.RecoveryKey) {
                     title = _t("Security Key mismatch");
                     content = (

src/components/views/directory/NetworkDropdown.tsx

@@ -38,8 +38,8 @@ export interface IPublicRoomDirectoryConfig {
     instanceId?: string;
 }
 
-const validServer = withValidation<undefined, { error?: MatrixError }>({
-    deriveData: async ({ value }): Promise<{ error?: MatrixError }> => {
+const validServer = withValidation<undefined, { error?: unknown }>({
+    deriveData: async ({ value }): Promise<{ error?: unknown }> => {
         try {
             // check if we can successfully load this server's room directory
             await MatrixClientPeg.safeGet().publicRooms({
@@ -63,7 +63,7 @@ const validServer = withValidation<undefined, { error?: MatrixError }>({
             test: async (_, { error }) => !error,
             valid: () => _t("Looks good"),
             invalid: ({ error }) =>
-                error?.errcode === "M_FORBIDDEN"
+                error instanceof MatrixError && error.errcode === "M_FORBIDDEN"
                     ? _t("You are not allowed to view this server's rooms list")
                     : _t("Can't find this server or its room list"),
         },

src/components/views/elements/EditableTextContainer.tsx

@@ -91,7 +91,7 @@ export default class EditableTextContainer extends React.Component<IProps, IStat
         } catch (error) {
             if (this.unmounted) return;
             this.setState({
-                errorString: error.toString(),
+                errorString: error instanceof Error ? error.message : String(error),
                 busy: false,
             });
         }

src/components/views/messages/MAudioBody.tsx

@@ -32,7 +32,7 @@ import RoomContext, { TimelineRenderingType } from "../../../contexts/RoomContex
 import MediaProcessingError from "./shared/MediaProcessingError";
 
 interface IState {
-    error?: Error;
+    error?: boolean;
     playback?: Playback;
 }
 
@@ -54,12 +54,12 @@ export default class MAudioBody extends React.PureComponent<IBodyProps, IState>
                 const blob = await this.props.mediaEventHelper!.sourceBlob.value;
                 buffer = await blob.arrayBuffer();
             } catch (e) {
-                this.setState({ error: e });
+                this.setState({ error: true });
                 logger.warn("Unable to decrypt audio message", e);
                 return; // stop processing the audio file
             }
         } catch (e) {
-            this.setState({ error: e });
+            this.setState({ error: true });
             logger.warn("Unable to decrypt/download audio message", e);
             return; // stop processing the audio file
         }

src/components/views/messages/MImageBody.tsx

@@ -50,7 +50,7 @@ interface IState {
     contentUrl: string | null;
     thumbUrl: string | null;
     isAnimated?: boolean;
-    error?: Error;
+    error?: unknown;
     imgError: boolean;
     imgLoaded: boolean;
     loadedImageDimensions?: {

src/components/views/settings/CrossSigningPanel.tsx

@@ -31,7 +31,7 @@ import AccessibleButton from "../elements/AccessibleButton";
 import { SettingsSubsectionText } from "./shared/SettingsSubsection";
 
 interface IState {
-    error?: Error;
+    error: boolean;
     crossSigningPublicKeysOnDevice?: boolean;
     crossSigningPrivateKeysInStorage?: boolean;
     masterPrivateKeyCached?: boolean;
@@ -47,7 +47,9 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
     public constructor(props: {}) {
         super(props);
 
-        this.state = {};
+        this.state = {
+            error: false,
+        };
     }
 
     public componentDidMount(): void {
@@ -125,7 +127,7 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
      * @param {bool} [forceReset] Bootstrap again even if keys already present
      */
     private bootstrapCrossSigning = async ({ forceReset = false }): Promise<void> => {
-        this.setState({ error: undefined });
+        this.setState({ error: false });
         try {
             const cli = MatrixClientPeg.safeGet();
             await cli.bootstrapCrossSigning({
@@ -143,7 +145,7 @@ export default class CrossSigningPanel extends React.PureComponent<{}, IState> {
                 setupNewCrossSigning: forceReset,
             });
         } catch (e) {
-            this.setState({ error: e });
+            this.setState({ error: true });
             logger.error("Error bootstrapping cross-signing", e);
         }
         if (this.unmounted) return;

src/components/views/settings/EventIndexPanel.tsx

@@ -239,7 +239,11 @@ export default class EventIndexPanel extends React.Component<{}, IState> {
                         <SettingsSubsectionText>
                             <details>
                                 <summary>{_t("Advanced")}</summary>
-                                <code>{EventIndexPeg.error.message}</code>
+                                <code>
+                                    {EventIndexPeg.error instanceof Error
+                                        ? EventIndexPeg.error.message
+                                        : _t("Unknown error")}
+                                </code>
                                 <p>
                                     <AccessibleButton key="delete" kind="danger" onClick={this.confirmEventStoreReset}>
                                         {_t("Reset")}

src/components/views/settings/JoinRuleSettings.tsx

@@ -40,7 +40,7 @@ export interface JoinRuleSettingsProps {
     room: Room;
     promptUpgrade?: boolean;
     closeSettingsFn(): void;
-    onError(error: Error): void;
+    onError(error: unknown): void;
     beforeChange?(joinRule: JoinRule): Promise<boolean>; // if returns false then aborts the change
     aliasWarning?: ReactNode;
 }

src/components/views/settings/SecureBackupPanel.tsx

@@ -35,7 +35,7 @@ import { SettingsSubsectionText } from "./shared/SettingsSubsection";
 
 interface IState {
     loading: boolean;
-    error: Error | null;
+    error: boolean;
     backupKeyStored: boolean | null;
     backupKeyCached: boolean | null;
     backupKeyWellFormed: boolean | null;
@@ -54,7 +54,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
 
         this.state = {
             loading: true,
-            error: null,
+            error: false,
             backupKeyStored: null,
             backupKeyCached: null,
             backupKeyWellFormed: null,
@@ -103,7 +103,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             const keyBackupResult = await MatrixClientPeg.safeGet().checkKeyBackup();
             this.setState({
                 loading: false,
-                error: null,
+                error: false,
                 backupInfo: keyBackupResult?.backupInfo ?? null,
                 backupSigStatus: keyBackupResult?.trustInfo ?? null,
             });
@@ -112,7 +112,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: e,
+                error: true,
                 backupInfo: null,
                 backupSigStatus: null,
             });
@@ -128,7 +128,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: null,
+                error: false,
                 backupInfo,
                 backupSigStatus,
             });
@@ -137,7 +137,7 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
             if (this.unmounted) return;
             this.setState({
                 loading: false,
-                error: e,
+                error: true,
                 backupInfo: null,
                 backupSigStatus: null,
             });
@@ -209,13 +209,13 @@ export default class SecureBackupPanel extends React.PureComponent<{}, IState> {
     };
 
     private resetSecretStorage = async (): Promise<void> => {
-        this.setState({ error: null });
+        this.setState({ error: false });
         try {
             await accessSecretStorage(async (): Promise<void> => {}, /* forceReset = */ true);
         } catch (e) {
             logger.error("Error resetting secret storage", e);
             if (this.unmounted) return;
-            this.setState({ error: e });
+            this.setState({ error: true });
         }
         if (this.unmounted) return;
         this.loadBackupStatus();

src/customisations/Security.ts

@@ -42,7 +42,7 @@ function getSecretStorageKey(): Uint8Array | null {
 }
 
 /* eslint-disable-next-line @typescript-eslint/no-unused-vars */
-function catchAccessSecretStorageError(e: Error): void {
+function catchAccessSecretStorageError(e: unknown): void {
     // E.g. notify the user in some way
 }
 

src/dispatcher/payloads/UploadPayload.ts

@@ -39,7 +39,7 @@ export interface UploadErrorPayload extends UploadPayload {
     /**
      * An error to describe what went wrong with the upload.
      */
-    error: Error;
+    error: unknown;
 }
 
 export interface UploadFinishedPayload extends UploadPayload {

src/hooks/useLocalEcho.ts

@@ -19,7 +19,7 @@ import { useState } from "react";
 export const useLocalEcho = <T>(
     currentFactory: () => T,
     setterFn: (value: T) => Promise<unknown>,
-    errorFn: (error: Error) => void,
+    errorFn: (error: unknown) => void,
 ): [value: T, handler: (value: T) => void] => {
     const [value, setValue] = useState(currentFactory);
     const handler = async (value: T): Promise<void> => {

src/i18n/strings/en_EN.json

@@ -1392,6 +1392,7 @@
     "%(brand)s is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom %(brand)s Desktop with <nativeLink>search components added</nativeLink>.": "%(brand)s is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom %(brand)s Desktop with <nativeLink>search components added</nativeLink>.",
     "%(brand)s can't securely cache encrypted messages locally while running in a web browser. Use <desktopLink>%(brand)s Desktop</desktopLink> for encrypted messages to appear in search results.": "%(brand)s can't securely cache encrypted messages locally while running in a web browser. Use <desktopLink>%(brand)s Desktop</desktopLink> for encrypted messages to appear in search results.",
     "Message search initialisation failed": "Message search initialisation failed",
+    "Unknown error": "Unknown error",
     "Hey you. You're the best!": "Hey you. You're the best!",
     "Size must be a number": "Size must be a number",
     "Custom font size can only be between %(min)s pt and %(max)s pt": "Custom font size can only be between %(min)s pt and %(max)s pt",
@@ -2764,7 +2765,6 @@
     "Remove %(count)s messages|one": "Remove 1 message",
     "Can't start voice message": "Can't start voice message",
     "You can't start a voice message as you are currently recording a live broadcast. Please end your live broadcast in order to start recording a voice message.": "You can't start a voice message as you are currently recording a live broadcast. Please end your live broadcast in order to start recording a voice message.",
-    "Unknown error": "Unknown error",
     "Unable to load commit detail: %(msg)s": "Unable to load commit detail: %(msg)s",
     "Unavailable": "Unavailable",
     "Changelog": "Changelog",

src/indexing/EventIndexPeg.ts

@@ -37,7 +37,7 @@ const INDEX_VERSION = 1;
  */
 export class EventIndexPeg {
     public index: EventIndex | null = null;
-    public error: Error | null = null;
+    public error: unknown;
 
     private _supportIsInstalled = false;
 

src/sentry.ts

@@ -174,7 +174,7 @@ async function getContexts(): Promise<Contexts> {
     };
 }
 
-export async function sendSentryReport(userText: string, issueUrl: string, error?: Error): Promise<void> {
+export async function sendSentryReport(userText: string, issueUrl: string, error?: unknown): Promise<void> {
     const sentryConfig = SdkConfig.getObject("sentry");
     if (!sentryConfig) return;
 

src/stores/OwnBeaconStore.ts

@@ -105,14 +105,13 @@ export class OwnBeaconStore extends AsyncStoreWithClient<OwnBeaconStoreState> {
      * Reset on successful publish of location
      */
     public readonly beaconLocationPublishErrorCounts = new Map<BeaconIdentifier, number>();
-    public readonly beaconUpdateErrors = new Map<BeaconIdentifier, Error>();
+    public readonly beaconUpdateErrors = new Map<BeaconIdentifier, unknown>();
     /**
      * ids of live beacons
      * ordered by creation time descending
      */
     private liveBeaconIds: BeaconIdentifier[] = [];
     private locationInterval?: number;
-    private geolocationError?: GeolocationError;
     private clearPositionWatch?: ClearWatchCallback;
     /**
      * Track when the last position was published
@@ -462,7 +461,11 @@ export class OwnBeaconStore extends AsyncStoreWithClient<OwnBeaconStoreState> {
         try {
             this.clearPositionWatch = watchPosition(this.onWatchedPosition, this.onGeolocationError);
         } catch (error) {
-            this.onGeolocationError(error?.message);
+            if (error instanceof Error) {
+                this.onGeolocationError(error.message as GeolocationError);
+            } else {
+                console.error("Unexpected error", error);
+            }
             // don't set locationInterval if geolocation failed to setup
             return;
         }
@@ -485,7 +488,6 @@ export class OwnBeaconStore extends AsyncStoreWithClient<OwnBeaconStoreState> {
         clearInterval(this.locationInterval);
         this.locationInterval = undefined;
         this.lastPublishedPositionTimestamp = undefined;
-        this.geolocationError = undefined;
 
         if (this.clearPositionWatch) {
             this.clearPositionWatch();
@@ -507,8 +509,7 @@ export class OwnBeaconStore extends AsyncStoreWithClient<OwnBeaconStoreState> {
     };
 
     private onGeolocationError = async (error: GeolocationError): Promise<void> => {
-        this.geolocationError = error;
-        logger.error("Geolocation failed", this.geolocationError);
+        logger.error("Geolocation failed", error);
 
         // other errors are considered non-fatal
         // and self recovering
@@ -531,7 +532,11 @@ export class OwnBeaconStore extends AsyncStoreWithClient<OwnBeaconStoreState> {
             const position = await getCurrentPosition();
             this.publishLocationToBeacons(mapGeolocationPositionToTimedGeo(position));
         } catch (error) {
-            this.onGeolocationError(error?.message);
+            if (error instanceof Error) {
+                this.onGeolocationError(error.message as GeolocationError);
+            } else {
+                console.error("Unexpected error", error);
+            }
         }
     };
 

src/stores/RoomViewStore.tsx

@@ -497,7 +497,7 @@ export class RoomViewStore extends EventEmitter {
                         action: Action.ViewRoomError,
                         room_id: null,
                         room_alias: payload.room_alias,
-                        err,
+                        err: err instanceof MatrixError ? err : undefined,
                     });
                     return;
                 }

src/utils/AutoDiscoveryUtils.tsx

@@ -43,11 +43,9 @@ export default class AutoDiscoveryUtils {
      * @param {string | Error} error The error to check
      * @returns {boolean} True if the error is a liveliness error.
      */
-    public static isLivelinessError(error?: string | Error | null): boolean {
+    public static isLivelinessError(error: unknown): boolean {
         if (!error) return false;
-        return !!LIVELINESS_DISCOVERY_ERRORS.find((e) =>
-            typeof error === "string" ? e === error : e === error.message,
-        );
+        return !!LIVELINESS_DISCOVERY_ERRORS.find((e) => (error instanceof Error ? e === error.message : e === error));
     }
 
     /**
@@ -58,7 +56,7 @@ export default class AutoDiscoveryUtils {
      * implementation for known values.
      * @returns {*} The state for the component, given the error.
      */
-    public static authComponentStateForError(err: string | Error | null, pageName = "login"): IAuthComponentState {
+    public static authComponentStateForError(err: unknown, pageName = "login"): IAuthComponentState {
         if (!err) {
             return {
                 serverIsAlive: true,
@@ -93,7 +91,7 @@ export default class AutoDiscoveryUtils {
         }
 
         let isFatalError = true;
-        const errorMessage = typeof err === "string" ? err : err.message;
+        const errorMessage = err instanceof Error ? err.message : err;
         if (errorMessage === AutoDiscovery.ERROR_INVALID_IDENTITY_SERVER) {
             isFatalError = false;
             title = _t("Cannot reach identity server");

src/utils/IdentityServerUtils.ts

@@ -40,7 +40,7 @@ export async function doesIdentityServerHaveTerms(matrixClient: MatrixClient, fu
         terms = await matrixClient.getTerms(SERVICE_TYPES.IS, fullUrl);
     } catch (e) {
         logger.error(e);
-        if (e.cors === "rejected" || (e instanceof HTTPError && e.httpStatus === 404)) {
+        if (e instanceof HTTPError && e.httpStatus === 404) {
             terms = null;
         } else {
             throw e;

src/utils/beacon/geolocation.ts

@@ -41,8 +41,8 @@ const isGeolocationPositionError = (error: unknown): error is GeolocationPositio
 /**
  * Maps GeolocationPositionError to our GeolocationError enum
  */
-export const mapGeolocationError = (error: GeolocationPositionError | Error): GeolocationError => {
-    logger.error("Geolocation failed", error?.message ?? error);
+export const mapGeolocationError = (error: GeolocationPositionError | Error | unknown): GeolocationError => {
+    logger.error("Geolocation failed", error);
 
     if (isGeolocationPositionError(error)) {
         switch (error?.code) {
@@ -55,7 +55,7 @@ export const mapGeolocationError = (error: GeolocationPositionError | Error): Ge
             default:
                 return GeolocationError.Default;
         }
-    } else if (error.message === GeolocationError.Unavailable) {
+    } else if (error instanceof Error && error.message === GeolocationError.Unavailable) {
         return GeolocationError.Unavailable;
     } else {
         return GeolocationError.Default;

src/utils/leave-behaviour.ts

@@ -105,8 +105,10 @@ export async function leaveRoomBehaviour(
             if (e instanceof MatrixError) {
                 const message = e.data.error || _t("Unexpected server error trying to leave the room");
                 results[roomId] = Object.assign(new Error(message), { errcode: e.data.errcode, data: e.data });
+            } else if (e instanceof Error) {
+                results[roomId] = e;
             } else {
-                results[roomId] = e || new Error("Failed to leave room for unknown causes");
+                results[roomId] = new Error("Failed to leave room for unknown causes");
             }
         }
     } else {

src/utils/location/useMap.ts

@@ -41,8 +41,11 @@ export const useMap = ({ interactive, bodyId, onError }: UseMapProps): MapLibreM
             try {
                 setMap(createMap(cli, !!interactive, bodyId, onError));
             } catch (error) {
+                console.error("Error encountered in useMap", error);
+                if (error instanceof Error) {
                     onError?.(error);
                 }
+            }
             return () => {
                 if (map) {
                     map.remove();

test/components/views/settings/EventIndexPanel-test.tsx

@@ -79,7 +79,7 @@ describe("<EventIndexPanel />", () => {
             jest.spyOn(SettingsStore, "getValueAt").mockReturnValue(true);
 
             // @ts-ignore private property
-            EventIndexPeg.error = { message: "Test error message" };
+            EventIndexPeg.error = new Error("Test error message");
         });
 
         it("displays an error when no event index is found and enabling not in progress", () => {

test/stores/OwnBeaconStore-test.ts

@@ -1101,7 +1101,10 @@ describe("OwnBeaconStore", () => {
             // still sharing
             expect(mockClient.unstable_setLiveBeacon).not.toHaveBeenCalled();
             expect(store.isMonitoringLiveLocation).toEqual(true);
-            expect(errorLogSpy).toHaveBeenCalledWith("Geolocation failed", "error message");
+            expect(errorLogSpy).toHaveBeenCalledWith(
+                "Geolocation failed",
+                expect.objectContaining({ message: "error message" }),
+            );
         });
 
         it("publishes last known position after 30s of inactivity", async () => {

tsconfig.json

@@ -13,8 +13,7 @@
         "declaration": true,
         "jsx": "react",
         "lib": ["es2020", "dom", "dom.iterable"],
-        "strict": true,
-        "useUnknownInCatchVariables": false
+        "strict": true
     },
     "include": [
         "./node_modules/matrix-js-sdk/src/@types/*.d.ts",