PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Move error dialog to the new check

Browse source 
So we just check for an existing call in one place where it doesn't race
This commit is contained in:
David Baker 2021-09-02 15:51:44 +01:00
parent edf6d13818
commit cd8e7e3076
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/CallHandler.tsx
View file

@ -754,7 +754,15 @@ export default class CallHandler extends EventEmitter {
console.log("Current turn creds expire in " + timeUntilTurnCresExpire + " ms"); console.log("Current turn creds expire in " + timeUntilTurnCresExpire + " ms");
const call = MatrixClientPeg.get().createCall(mappedRoomId); const call = MatrixClientPeg.get().createCall(mappedRoomId);
try {
this.addCallForRoom(roomId, call); this.addCallForRoom(roomId, call);
} catch (e) {
Modal.createTrackedDialog('Call Handler', 'Existing Call with user', ErrorDialog, {
title: _t('Already in call'),
description: _t("You're already in a call with this person."),
});
return;
}
if (transferee) { if (transferee) {
this.transferees[call.callId] = transferee; this.transferees[call.callId] = transferee;
} }
@ -806,14 +814,8 @@ export default class CallHandler extends EventEmitter {
return; return;
} }
console.log("getting call for room " + room.roomId); // We leave the check for whether there's already a call in this room until later,
if (this.getCallForRoom(room.roomId)) { // otherwise it can race.
Modal.createTrackedDialog('Call Handler', 'Existing Call with user', ErrorDialog, {
title: _t('Already in call'),
description: _t("You're already in a call with this person."),
});
return;
}
const members = room.getJoinedMembers(); const members = room.getJoinedMembers();
if (members.length <= 1) { if (members.length <= 1) {