PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #4461 from matrix-org/t3chguy/register_email_not_possible

Browse source 
If user cannot set email during registration don't tell them to
This commit is contained in:
Michael Telatynski 2020-04-22 13:59:43 +01:00 committed by GitHub
commit ca3ddb3760
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/auth/RegistrationForm.js
View file

@ -102,11 +102,15 @@ export default createReactClass({
"No identity server is configured so you cannot add an email address in order to " + "No identity server is configured so you cannot add an email address in order to " +
"reset your password in the future.", "reset your password in the future.",
); );
} else { } else if (this._showEmail()) {
desc = _t( desc = _t(
"If you don't specify an email address, you won't be able to reset your password. " + "If you don't specify an email address, you won't be able to reset your password. " +
"Are you sure?", "Are you sure?",
); );
} else {
// user can't set an e-mail so don't prompt them to
self._doSubmit(ev);
return;
} }
const QuestionDialog = sdk.getComponent("dialogs.QuestionDialog"); const QuestionDialog = sdk.getComponent("dialogs.QuestionDialog");

34
test/end-to-end-tests/synapse/config-templates/consent/homeserver.yaml
View file

@ -642,7 +642,7 @@ enable_registration: true
# Explicitly disable asking for MSISDNs from the registration # Explicitly disable asking for MSISDNs from the registration
# flow (overrides registrations_require_3pid if MSISDNs are set as required) # flow (overrides registrations_require_3pid if MSISDNs are set as required)
# #
#disable_msisdn_registration: true disable_msisdn_registration: false
# Mandate that users are only allowed to associate certain formats of # Mandate that users are only allowed to associate certain formats of
# 3PIDs with accounts on this server. # 3PIDs with accounts on this server.
@ -882,22 +882,22 @@ password_config:
# If your SMTP server requires authentication, the optional smtp_user & # If your SMTP server requires authentication, the optional smtp_user &
# smtp_pass variables should be used # smtp_pass variables should be used
# #
#email: email:
# enable_notifs: false enable_notifs: false
# smtp_host: "localhost" smtp_host: "localhost"
# smtp_port: 25 smtp_port: 25
# smtp_user: "exampleusername" smtp_user: "exampleusername"
# smtp_pass: "examplepassword" smtp_pass: "examplepassword"
# require_transport_security: False require_transport_security: False
# notif_from: "Your Friendly %(app)s Home Server <noreply@example.com>" notif_from: "Your Friendly %(app)s Home Server <noreply@example.com>"
# app_name: Matrix app_name: Matrix
# # if template_dir is unset, uses the example templates that are part of # if template_dir is unset, uses the example templates that are part of
# # the Synapse distribution. # the Synapse distribution.
# #template_dir: res/templates #template_dir: res/templates
# notif_template_html: notif_mail.html notif_template_html: notif_mail.html
# notif_template_text: notif_mail.txt notif_template_text: notif_mail.txt
# notif_for_new_users: True notif_for_new_users: True
# riot_base_url: "http://localhost/riot" riot_base_url: "http://localhost/riot"
#password_providers: #password_providers: