PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Move multi-repo linking to workflow section

Browse source
This commit is contained in:
J. Ryan Stinnett 2020-03-18 10:21:28 +00:00
parent 1aecc3d7e5
commit bd8b3a9046
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/review.md
View file

@ -37,12 +37,12 @@ When reviewing code, here are some things we look for and also things we avoid:
* Take the time to thank and point out good code changes * Take the time to thank and point out good code changes
* Using softer language like "please" and "what do you think?" goes a long way * Using softer language like "please" and "what do you think?" goes a long way
towards making others feel like colleagues working towards a common goal towards making others feel like colleagues working towards a common goal
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.
### Workflow ### Workflow
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.
* Avoid force pushing to a PR after first round of review * Avoid force pushing to a PR after first round of review
* Use merge commits when landing * Use merge commits when landing
* PR author merges after review (assuming they have write access) * PR author merges after review (assuming they have write access)