PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Replace MatrixClient.prepareToEncrypt by MatrixClient.getCrypto.prepareToEncrypt (#146)

Browse source
This commit is contained in:
Florian Duros 2024-10-15 09:50:38 +02:00 committed by GitHub
parent 503d9004d1
commit bce02634f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/LegacyCallHandler.tsx
View file

@ -367,7 +367,7 @@ export default class LegacyCallHandler extends EventEmitter {
// the mapped one: that's where we'll send the events.
const cli = MatrixClientPeg.safeGet();
const room = cli.getRoom(call.roomId);
if (room) cli.prepareToEncrypt(room);
if (room) cli.getCrypto()?.prepareToEncrypt(room);
};
public getCallById(callId: string): MatrixCall | null {

2
src/components/views/rooms/SendMessageComposer.tsx
View file

@ -268,7 +268,7 @@ export class SendMessageComposer extends React.Component<ISendMessageComposerPro
if (this.props.mxClient.isCryptoEnabled() && this.props.mxClient.isRoomEncrypted(this.props.room.roomId)) {
this.prepareToEncrypt = throttle(
() => {
this.props.mxClient.prepareToEncrypt(this.props.room);
this.props.mxClient.getCrypto()?.prepareToEncrypt(this.props.room);
},
60000,
{ leading: true, trailing: false },

1
test/LegacyCallHandler-test.ts
View file

@ -588,7 +588,6 @@ describe("LegacyCallHandler without third party protocols", () => {
jest.spyOn(MatrixClientPeg.safeGet(), "supportsVoip").mockReturnValue(true);
MatrixClientPeg.safeGet().isFallbackICEServerAllowed = jest.fn();
MatrixClientPeg.safeGet().prepareToEncrypt = jest.fn();
MatrixClientPeg.safeGet().pushRules = {
global: {

7
test/components/views/rooms/SendMessageComposer-test.tsx
View file

@ -573,10 +573,9 @@ describe("<SendMessageComposer/>", () => {
const cli = stubClient();
cli.isCryptoEnabled = jest.fn().mockReturnValue(true);
cli.isRoomEncrypted = jest.fn().mockReturnValue(true);
cli.prepareToEncrypt = jest.fn();
const room = mkStubRoom("!roomId:server", "Room", cli);
expect(cli.prepareToEncrypt).not.toHaveBeenCalled();
expect(cli.getCrypto()!.prepareToEncrypt).not.toHaveBeenCalled();
const { container } = render(
<MatrixClientContext.Provider value={cli}>
@ -588,9 +587,9 @@ describe("<SendMessageComposer/>", () => {
// Does not trigger on keydown as that'll cause false negatives for global shortcuts
await userEvent.type(composer, "[ControlLeft>][KeyK][/ControlLeft]");
expect(cli.prepareToEncrypt).not.toHaveBeenCalled();
expect(cli.getCrypto()!.prepareToEncrypt).not.toHaveBeenCalled();
await userEvent.type(composer, "Hello");
expect(cli.prepareToEncrypt).toHaveBeenCalled();
expect(cli.getCrypto()!.prepareToEncrypt).toHaveBeenCalled();
});
});

1
test/test-utils/test-utils.ts
View file

@ -133,6 +133,7 @@ export function createTestClient(): MatrixClient {
isEncryptionEnabledInRoom: jest.fn(),
getVerificationRequestsToDeviceInProgress: jest.fn().mockReturnValue([]),
setDeviceIsolationMode: jest.fn(),
prepareToEncrypt: jest.fn(),
}),
getPushActionsForEvent: jest.fn(),