PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Don't render context menu button if mxEvent is missing

Browse source 
The button is useless and doesn't work if we're viewing an avatar

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This commit is contained in:
Šimon Brandner 2021-04-13 08:11:09 +02:00
parent e1446f01e4
commit b1091a22a3
No known key found for this signature in database
GPG key ID: 9760693FDD98A790
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/components/views/elements/ImageView.tsx
View file

@ -359,6 +359,19 @@ export default class ImageView extends React.Component<IProps, IState> {
);
}
let contextMenuButton;
if (this.props.mxEvent) {
contextMenuButton = (
<ContextMenuTooltipButton
className="mx_ImageView_button mx_ImageView_button_more"
title={_t("Options")}
onClick={this.onOpenContextMenu}
inputRef={this.contextMenuButton}
isExpanded={this.state.contextMenuDisplayed}
/>
);
}
return (
<FocusLock
returnFocus={true}
@ -397,13 +410,7 @@ export default class ImageView extends React.Component<IProps, IState> {
title={_t("Download")}
onClick={ this.onDownloadClick }>
</AccessibleTooltipButton>
<ContextMenuTooltipButton
className="mx_ImageView_button mx_ImageView_button_more"
title={_t("Options")}
onClick={this.onOpenContextMenu}
inputRef={this.contextMenuButton}
isExpanded={this.state.contextMenuDisplayed}
/>
{contextMenuButton}
<AccessibleTooltipButton
className="mx_ImageView_button mx_ImageView_button_close"
title={_t("Close")}