Merge remote-tracking branch 'origin/develop' into develop

.eslintrc.js

@@ -29,6 +29,10 @@ module.exports = {
         // so we replace it with a version that is class property aware
         "babel/no-invalid-this": "error",
 
+        // We appear to follow this most of the time, so let's enforce it instead
+        // of occasionally following it (or catching it in review)
+        "keyword-spacing": "error",
+
         /** react **/
         // This just uses the react plugin to help eslint known when
         // variables have been used in JSX

src/components/structures/RoomView.js

@@ -303,7 +303,7 @@ module.exports = React.createClass({
 
         // Check if user has previously chosen to hide the app drawer for this
         // room. If so, do not show apps
-        let hideWidgetDrawer = localStorage.getItem(
+        const hideWidgetDrawer = localStorage.getItem(
             room.roomId + "_hide_widget_drawer");
 
         if (hideWidgetDrawer === "true") {
@@ -713,7 +713,7 @@ module.exports = React.createClass({
             return;
         }
 
-        const joinedMembers = room.currentState.getMembers().filter(m => m.membership === "join" || m.membership === "invite");
+        const joinedMembers = room.currentState.getMembers().filter((m) => m.membership === "join" || m.membership === "invite");
         this.setState({isAlone: joinedMembers.length === 1});
     },
 

src/components/structures/login/Login.js

@@ -113,7 +113,7 @@ module.exports = React.createClass({
                             <div className="mx_Login_smallError">
                                 { _t('Please note you are logging into the %(hs)s server, not matrix.org.',
                                     {
-                                        hs: this.props.defaultHsUrl.replace(/^https?:\/\//, '')
+                                        hs: this.props.defaultHsUrl.replace(/^https?:\/\//, ''),
                                     })
                                 }
                             </div>
@@ -393,8 +393,7 @@ module.exports = React.createClass({
         const theme = SettingsStore.getValue("theme");
         if (theme !== "status") {
             header = <h2>{ _t('Sign in') }</h2>;
-        }
-        else {
+        } else {
             if (!this.state.errorText) {
                 header = <h2>{ _t('Sign in to get started') }</h2>;
             }

src/components/structures/login/Registration.js

@@ -399,8 +399,7 @@ module.exports = React.createClass({
         // FIXME: remove hardcoded Status team tweaks at some point
         if (theme === 'status' && this.state.errorText) {
             header = <div className="mx_Login_error">{ this.state.errorText }</div>;
-        }
-        else {
+        } else {
             header = <h2>{ _t('Create an account') }</h2>;
             if (this.state.errorText) {
                 errorText = <div className="mx_Login_error">{ this.state.errorText }</div>;

src/components/views/elements/MemberEventListSummary.js

@@ -304,7 +304,7 @@ module.exports = React.createClass({
             return items[0];
         } else if (remaining > 0) {
             items = items.slice(0, itemLimit);
-            return _t("%(items)s and %(count)s others", { items: items.join(', '), count: remaining } )
+            return _t("%(items)s and %(count)s others", { items: items.join(', '), count: remaining } );
         } else {
             const lastItem = items.pop();
             return _t("%(items)s and %(lastItem)s", { items: items.join(', '), lastItem: lastItem });

src/components/views/login/PasswordLogin.js

@@ -146,7 +146,7 @@ class PasswordLogin extends React.Component {
                     onChange={this.onUsernameChanged}
                     placeholder={SdkConfig.get().disable_custom_urls ?
                                       _t("Username on %(hs)s", {
-                                        hs: this.props.hsUrl.replace(/^https?:\/\//, '')
+                                        hs: this.props.hsUrl.replace(/^https?:\/\//, ''),
                                       }) : _t("User name")}
                     value={this.state.username}
                     autoFocus

src/components/views/rooms/RoomSettings.js

@@ -309,9 +309,9 @@ module.exports = React.createClass({
         }
 
         // url preview settings
-        let ps = this.saveUrlPreviewSettings();
+        const ps = this.saveUrlPreviewSettings();
         if (ps.length > 0) {
-            ps.map(p => promises.push(p));
+            ps.map((p) => promises.push(p));
         }
 
         // related groups
@@ -584,7 +584,7 @@ module.exports = React.createClass({
         const roomState = this.props.room.currentState;
         const isEncrypted = cli.isRoomEncrypted(this.props.room.roomId);
 
-        let settings = (
+        const settings = (
             <SettingsFlag name="blacklistUnverifiedDevices"
                           level={SettingLevel.ROOM_DEVICE}
                           roomId={this.props.room.roomId}
@@ -747,7 +747,7 @@ module.exports = React.createClass({
             }
         });
 
-        var tagsSection = null;
+        let tagsSection = null;
         if (canSetTag || self.state.tags) {
             tagsSection =
                 <div className="mx_RoomSettings_tags">