PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

hide lazy loading behind feature flag

Browse source
This commit is contained in:
Bruno Windels 2018-07-16 15:07:53 +02:00
parent 866b4bb067
commit af07d73432
3 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/MatrixClientPeg.js
View file

@ -107,7 +107,9 @@ class MatrixClientPeg {
// the react sdk doesn't work without this, so don't allow // the react sdk doesn't work without this, so don't allow
opts.pendingEventOrdering = "detached"; opts.pendingEventOrdering = "detached";
if (SettingsStore.isFeatureEnabled('feature_lazyloading')) {
opts.filter = await this.matrixClient.createFilter(FILTER_CONTENT); opts.filter = await this.matrixClient.createFilter(FILTER_CONTENT);
}
try { try {
const promise = this.matrixClient.store.startup(); const promise = this.matrixClient.store.startup();

4
src/components/structures/RoomView.js
View file

@ -314,9 +314,13 @@ module.exports = React.createClass({
this.setState({isPeeking: false}); this.setState({isPeeking: false});
//viewing a previously joined room, try to lazy load members //viewing a previously joined room, try to lazy load members
// lazy load members if enabled
if (SettingsStore.isFeatureEnabled('feature_lazyloading')) {
MatrixClientPeg.get().loadRoomMembersIfNeeded(room.roomId); MatrixClientPeg.get().loadRoomMembersIfNeeded(room.roomId);
} }
} }
}
}, },
_shouldShowApps: function(room) { _shouldShowApps: function(room) {

5
src/settings/Settings.js
View file

@ -83,6 +83,11 @@ export const SETTINGS = {
supportedLevels: LEVELS_FEATURE, supportedLevels: LEVELS_FEATURE,
default: false, default: false,
}, },
"feature_lazyloading": {
isFeature: true,
displayName: _td("Increase performance by loading room members on first view"),
supportedLevels: LEVELS_FEATURE,
},
"MessageComposerInput.dontSuggestEmoji": { "MessageComposerInput.dontSuggestEmoji": {
supportedLevels: LEVELS_ACCOUNT_SETTINGS, supportedLevels: LEVELS_ACCOUNT_SETTINGS,
displayName: _td('Disable Emoji suggestions while typing'), displayName: _td('Disable Emoji suggestions while typing'),