PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Keep one source of truth (the Notifier) when toggling notification state. Fixes notifications.

Browse source
This commit is contained in:
Kegan Dougal 2015-12-23 17:06:30 +00:00
parent a279dce027
commit abb170ebde
1 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/components/structures/UserSettings.js
View file

@ -46,7 +46,6 @@ module.exports = React.createClass({
componentWillMount: function() {
var self = this;
this._refreshFromServer();
},
@ -80,9 +79,7 @@ module.exports = React.createClass({
onAction: function(payload) {
if (payload.action === "notifier_enabled") {
this.setState({
enableNotifications : UserSettingsStore.getEnableNotifications()
});
this.forceUpdate();
}
},
@ -143,11 +140,7 @@ module.exports = React.createClass({
},
onEnableNotificationsChange: function(event) {
// don't bother waiting for Save to be clicked, as that'd be silly
UserSettingsStore.setEnableNotifications( this.refs.enableNotifications.value );
this.setState({
enableNotifications : UserSettingsStore.getEnableNotifications()
});
UserSettingsStore.setEnableNotifications(event.target.checked);
},
render: function() {
@ -245,7 +238,7 @@ module.exports = React.createClass({
<input id="enableNotifications"
ref="enableNotifications"
type="checkbox"
checked={ this.state.enableNotifications }
checked={ UserSettingsStore.getEnableNotifications() }
onChange={ this.onEnableNotificationsChange } />
</div>
<div className="mx_UserSettings_notifLabelCell">