From a579ea95db812423055e8ab0f72c15bed4e62393 Mon Sep 17 00:00:00 2001
From: Jorik Schellekens <joriksch@gmail.com>
Date: Thu, 18 Jun 2020 13:28:24 +0100
Subject: [PATCH] Lint and i18n

---
 .../tabs/user/AppearanceUserSettingsTab.tsx   | 36 +++++++++----------
 src/i18n/strings/en_EN.json                   |  1 +
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx b/src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
index 0620626181..0f1779270b 100644
--- a/src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
+++ b/src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
@@ -35,27 +35,27 @@ interface IProps {
 }
 
 interface IThemeState {
-    theme: string,
-    useSystemTheme: boolean,
+    theme: string;
+    useSystemTheme: boolean;
 }
 
 export interface CustomThemeMessage {
-    isError: boolean,
-    text: string
+    isError: boolean;
+    text: string;
 };
 
 interface IState extends IThemeState {
     // String displaying the current selected fontSize.
     // Needs to be string for things like '17.' without
     // trailing 0s.
-    fontSize: string,
-    customThemeUrl: string,
-    customThemeMessage: CustomThemeMessage,
-    useCustomFontSize: boolean,
-    useIRCLayout: boolean,
+    fontSize: string;
+    customThemeUrl: string;
+    customThemeMessage: CustomThemeMessage;
+    useCustomFontSize: boolean;
+    useIRCLayout: boolean;
 }
 
-const MESSAGE_PREVIEW_TEXT = "Hey you. You're the best"
+const MESSAGE_PREVIEW_TEXT = _t("Hey you. You're the best!");
 
 export default class AppearanceUserSettingsTab extends React.Component<IProps, IState> {
 
@@ -70,7 +70,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
             customThemeUrl: "",
             customThemeMessage: {isError: false, text: ""},
             useCustomFontSize: SettingsStore.getValue("useCustomFontSize"),
-            useIRCLayout: SettingsStore.getValue("useIRCLayout", null),
+            useIRCLayout: SettingsStore.getValue("useIRCLayout"),
         };
     }
 
@@ -277,7 +277,7 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
                         return <StyledRadioButton
                             key={theme.id}
                             value={theme.id}
-                            name={"theme"}
+                            name="theme"
                             disabled={this.state.useSystemTheme}
                             checked={!this.state.useSystemTheme && theme.id === this.state.theme}
                             className={"mx_ThemeSelector_" + theme.id}
@@ -350,11 +350,11 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
                     <MessagePreview
                         className="mx_AppearanceUserSettingsTab_Layout_RadioButton_preview"
                         message={MESSAGE_PREVIEW_TEXT}
-                        useIRCLayout={true}
+                        useIRCLayout="true"
                     />
                     <StyledRadioButton
-                        name={"layout"}
-                        value={true}
+                        name="layout"
+                        value="true"
                         checked={this.state.useIRCLayout}
                         onChange={this.onLayoutChange}
                     >
@@ -366,11 +366,11 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
                     <MessagePreview
                         className="mx_AppearanceUserSettingsTab_Layout_RadioButton_preview"
                         message={MESSAGE_PREVIEW_TEXT}
-                        useIRCLayout={false}
+                        useIRCLayout="false"
                     />
                     <StyledRadioButton
-                        name={"layout"}
-                        value={false}
+                        name="layout"
+                        value="false"
                         checked={!this.state.useIRCLayout}
                         onChange={this.onLayoutChange}
                     >
diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
index 157d83ba57..6a16f947f4 100644
--- a/src/i18n/strings/en_EN.json
+++ b/src/i18n/strings/en_EN.json
@@ -771,6 +771,7 @@
     "Downloading update...": "Downloading update...",
     "New version available. <a>Update now.</a>": "New version available. <a>Update now.</a>",
     "Check for update": "Check for update",
+    "Hey you. You're the best!": "Hey you. You're the best!",
     "Size must be a number": "Size must be a number",
     "Custom font size can only be between %(min)s pt and %(max)s pt": "Custom font size can only be between %(min)s pt and %(max)s pt",
     "Use between %(min)s pt and %(max)s pt": "Use between %(min)s pt and %(max)s pt",