PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #3557 from matrix-org/jryans/scroll-unmount-guard

Browse source 
Abort scroll updates when already unmounted
This commit is contained in:
David Baker 2019-10-21 17:05:53 +01:00 committed by GitHub
commit a3dbf881e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/components/structures/ScrollPanel.js
View file

@ -677,6 +677,11 @@ module.exports = createReactClass({
debuglog("updateHeight getting straight to business, no scrolling going on."); debuglog("updateHeight getting straight to business, no scrolling going on.");
} }
// We might have unmounted since the timer finished, so abort if so.
if (this.unmounted) {
return;
}
const sn = this._getScrollNode(); const sn = this._getScrollNode();
const itemlist = this.refs.itemlist; const itemlist = this.refs.itemlist;
const contentHeight = this._getMessagesHeight(); const contentHeight = this._getMessagesHeight();