From a20d23daf317786728e71793411abdd8ce649e8a Mon Sep 17 00:00:00 2001
From: "J. Ryan Stinnett" <jryans@gmail.com>
Date: Tue, 23 Apr 2019 15:05:03 +0100
Subject: [PATCH] Remove older password length check

Now that we have a fancier password complexity check, remove the older minimum
length to avoid the feeling of two password style guides fighting each other.
---
 src/components/structures/auth/Registration.js |  3 ---
 src/components/views/auth/RegistrationForm.js  | 11 -----------
 src/i18n/strings/en_EN.json                    |  1 -
 3 files changed, 15 deletions(-)

diff --git a/src/components/structures/auth/Registration.js b/src/components/structures/auth/Registration.js
index 87fea3ec4b..df87c1b9ca 100644
--- a/src/components/structures/auth/Registration.js
+++ b/src/components/structures/auth/Registration.js
@@ -28,8 +28,6 @@ import SdkConfig from '../../../SdkConfig';
 import { messageForResourceLimitError } from '../../../utils/ErrorUtils';
 import * as ServerType from '../../views/auth/ServerTypeSelector';
 
-const MIN_PASSWORD_LENGTH = 6;
-
 // Phases
 // Show controls to configure server details
 const PHASE_SERVER_DETAILS = 0;
@@ -482,7 +480,6 @@ module.exports = React.createClass({
                 defaultPhoneCountry={this.state.formVals.phoneCountry}
                 defaultPhoneNumber={this.state.formVals.phoneNumber}
                 defaultPassword={this.state.formVals.password}
-                minPasswordLength={MIN_PASSWORD_LENGTH}
                 onRegisterClick={this.onFormSubmit}
                 onEditServerDetailsClick={onEditServerDetailsClick}
                 flows={this.state.flows}
diff --git a/src/components/views/auth/RegistrationForm.js b/src/components/views/auth/RegistrationForm.js
index 2ba01dc0c6..21c2743301 100644
--- a/src/components/views/auth/RegistrationForm.js
+++ b/src/components/views/auth/RegistrationForm.js
@@ -48,7 +48,6 @@ module.exports = React.createClass({
         defaultPhoneNumber: PropTypes.string,
         defaultUsername: PropTypes.string,
         defaultPassword: PropTypes.string,
-        minPasswordLength: PropTypes.number,
         onRegisterClick: PropTypes.func.isRequired, // onRegisterClick(Object) => ?Promise
         onEditServerDetailsClick: PropTypes.func,
         flows: PropTypes.arrayOf(PropTypes.object).isRequired,
@@ -61,7 +60,6 @@ module.exports = React.createClass({
 
     getDefaultProps: function() {
         return {
-            minPasswordLength: 6,
             onValidationChange: console.error,
         };
     },
@@ -256,15 +254,6 @@ module.exports = React.createClass({
                 test: ({ value, allowEmpty }) => allowEmpty || !!value,
                 invalid: () => _t("Enter password"),
             },
-            {
-                key: "minLength",
-                test: function({ value }) {
-                    return !value || value.length >= this.props.minPasswordLength;
-                },
-                invalid: function() {
-                    return _t("Too short (min %(length)s)", { length: this.props.minPasswordLength });
-                },
-            },
             {
                 key: "complexity",
                 test: async function({ value }) {
diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
index 262e143ae6..d1ff8b2695 100644
--- a/src/i18n/strings/en_EN.json
+++ b/src/i18n/strings/en_EN.json
@@ -1326,7 +1326,6 @@
     "Enter email address (required on this homeserver)": "Enter email address (required on this homeserver)",
     "Doesn't look like a valid email address": "Doesn't look like a valid email address",
     "Enter password": "Enter password",
-    "Too short (min %(length)s)": "Too short (min %(length)s)",
     "Nice, strong password!": "Nice, strong password!",
     "Keep going...": "Keep going...",
     "Passwords don't match": "Passwords don't match",