PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Clone reads of account data to prevent mutation

Browse source
This commit is contained in:
Travis Ralston 2020-06-22 11:24:04 -06:00
parent fe65b7631d
commit 9e3c101172
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/settings/handlers/AccountSettingsHandler.js
View file

@ -162,7 +162,7 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
const event = cli.getAccountData(eventType); const event = cli.getAccountData(eventType);
if (!event || !event.getContent()) return null; if (!event || !event.getContent()) return null;
return event.getContent(); return JSON.parse(JSON.stringify(event.getContent())); // clone to prevent mutation
} }
_notifyBreadcrumbsUpdate(event) { _notifyBreadcrumbsUpdate(event) {