PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Only respect X-Needs-Percy in the Merge Queue (#10520)

Browse source 
* Enable merge queues

* Iterate

* Iterate

* iterate

* Only respect X-Needs-Percy in the Merge Queue
This commit is contained in:
Michael Telatynski 2023-04-06 15:30:56 +01:00 committed by GitHub
parent 818e8292cb
commit 9cecac0cee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/cypress.yaml vendored
View file

@ -65,7 +65,7 @@ jobs:
if: | if: |
github.event.workflow_run.event == 'schedule' || github.event.workflow_run.event == 'schedule' ||
( (
github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.event == 'merge_queue' &&
contains(fromJSON(steps.prdetails.outputs.data).labels.*.name, 'X-Needs-Percy') contains(fromJSON(steps.prdetails.outputs.data).labels.*.name, 'X-Needs-Percy')
) )
run: echo "::set-output name=value::1" run: echo "::set-output name=value::1"

3
docs/cypress.md
View file

@ -215,7 +215,8 @@ nightly build at approximately 04:00 UTC every day. (The schedule is defined in
enabled/disabled in [cypress.yaml](../.github/workflows/cypress.yaml).) enabled/disabled in [cypress.yaml](../.github/workflows/cypress.yaml).)
If your pull request makes visual changes, you are encouraged to request Percy If your pull request makes visual changes, you are encouraged to request Percy
to run by adding the label `X-Needs-Percy` to the PR. This will help us find any to run by adding the label `X-Needs-Percy` to the PR, these will only run in
the merge queue to save snapshots. This will help us find any
visual bugs or validate visual changes at the time they are made, instead of visual bugs or validate visual changes at the time they are made, instead of
having to figure it out later after the nightly build. If you don't have having to figure it out later after the nightly build. If you don't have
permission to add a label, please ask your reviewer to do it. Note: it's best to permission to add a label, please ask your reviewer to do it. Note: it's best to