Only respect X-Needs-Percy in the Merge Queue (#10520)
* Enable merge queues * Iterate * Iterate * iterate * Only respect X-Needs-Percy in the Merge Queue
This commit is contained in:
parent
818e8292cb
commit
9cecac0cee
2 changed files with 3 additions and 2 deletions
2
.github/workflows/cypress.yaml
vendored
2
.github/workflows/cypress.yaml
vendored
|
@ -65,7 +65,7 @@ jobs:
|
|||
if: |
|
||||
github.event.workflow_run.event == 'schedule' ||
|
||||
(
|
||||
github.event.workflow_run.event == 'pull_request' &&
|
||||
github.event.workflow_run.event == 'merge_queue' &&
|
||||
contains(fromJSON(steps.prdetails.outputs.data).labels.*.name, 'X-Needs-Percy')
|
||||
)
|
||||
run: echo "::set-output name=value::1"
|
||||
|
|
|
@ -215,7 +215,8 @@ nightly build at approximately 04:00 UTC every day. (The schedule is defined in
|
|||
enabled/disabled in [cypress.yaml](../.github/workflows/cypress.yaml).)
|
||||
|
||||
If your pull request makes visual changes, you are encouraged to request Percy
|
||||
to run by adding the label `X-Needs-Percy` to the PR. This will help us find any
|
||||
to run by adding the label `X-Needs-Percy` to the PR, these will only run in
|
||||
the merge queue to save snapshots. This will help us find any
|
||||
visual bugs or validate visual changes at the time they are made, instead of
|
||||
having to figure it out later after the nightly build. If you don't have
|
||||
permission to add a label, please ask your reviewer to do it. Note: it's best to
|
||||
|
|
Loading…
Reference in a new issue