PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Remove unspecced original_event field from the readEventRelations response (#9349)

Browse source 
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
This commit is contained in:
Dominik Henneke 2022-10-04 19:54:26 +02:00 committed by GitHub
parent 16c3efead5
commit 99488b84ec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/stores/widgets/StopGapWidgetDriver.ts
View file

@ -434,7 +434,6 @@ export class StopGapWidgetDriver extends WidgetDriver {
} }
const { const {
originalEvent,
events, events,
nextBatch, nextBatch,
prevBatch, prevBatch,
@ -451,7 +450,6 @@ export class StopGapWidgetDriver extends WidgetDriver {
}); });
return { return {
originalEvent: originalEvent?.getEffectiveEvent(),
chunk: events.map(e => e.getEffectiveEvent()), chunk: events.map(e => e.getEffectiveEvent()),
nextBatch, nextBatch,
prevBatch, prevBatch,

21
test/stores/widgets/StopGapWidgetDriver-test.ts
View file

@ -209,7 +209,6 @@ describe("StopGapWidgetDriver", () => {
}); });
await expect(driver.readEventRelations('$event')).resolves.toEqual({ await expect(driver.readEventRelations('$event')).resolves.toEqual({
originalEvent: expect.objectContaining({ content: {} }),
chunk: [], chunk: [],
nextBatch: undefined, nextBatch: undefined,
prevBatch: undefined, prevBatch: undefined,
@ -218,24 +217,6 @@ describe("StopGapWidgetDriver", () => {
expect(client.relations).toBeCalledWith('!this-room-id', '$event', null, null, {}); expect(client.relations).toBeCalledWith('!this-room-id', '$event', null, null, {});
}); });
it('reads related events if the original event is missing', async () => {
client.relations.mockResolvedValue({
// the relations function can return an undefined event, even
// though the typings don't permit an undefined value.
originalEvent: undefined as any,
events: [],
});
await expect(driver.readEventRelations('$event', '!room-id')).resolves.toEqual({
originalEvent: undefined,
chunk: [],
nextBatch: undefined,
prevBatch: undefined,
});
expect(client.relations).toBeCalledWith('!room-id', '$event', null, null, {});
});
it('reads related events from a selected room', async () => { it('reads related events from a selected room', async () => {
client.relations.mockResolvedValue({ client.relations.mockResolvedValue({
originalEvent: new MatrixEvent(), originalEvent: new MatrixEvent(),
@ -244,7 +225,6 @@ describe("StopGapWidgetDriver", () => {
}); });
await expect(driver.readEventRelations('$event', '!room-id')).resolves.toEqual({ await expect(driver.readEventRelations('$event', '!room-id')).resolves.toEqual({
originalEvent: expect.objectContaining({ content: {} }),
chunk: [ chunk: [
expect.objectContaining({ content: {} }), expect.objectContaining({ content: {} }),
expect.objectContaining({ content: {} }), expect.objectContaining({ content: {} }),
@ -272,7 +252,6 @@ describe("StopGapWidgetDriver", () => {
25, 25,
'f', 'f',
)).resolves.toEqual({ )).resolves.toEqual({
originalEvent: expect.objectContaining({ content: {} }),
chunk: [], chunk: [],
nextBatch: undefined, nextBatch: undefined,
prevBatch: undefined, prevBatch: undefined,