PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Enable tests fixed by https://github.com/matrix-org/matrix-js-sdk/pull/3800 (#11764)

Browse source 
* Update comments on flaky tests

* Enable a test that is fixed by matrix-js-sdk#3800
This commit is contained in:
Andy Balaam 2023-11-15 09:05:52 +00:00 committed by GitHub
parent f6ef476f79
commit 9564009eba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cypress/e2e/read-receipts/redactions.spec.ts
View file

@ -501,7 +501,7 @@ describe("Read receipts", () => {
goTo(room2); goTo(room2);
assertReadThread("Root"); assertReadThread("Root");
}); });
// XXX: fails because sometimes the room is still unread after opening the thread (initially) // XXX: fails because it flakes - sometimes the room is still unread after opening the thread (initially)
it.skip("Reacting to a redacted message leaves the thread read", () => { it.skip("Reacting to a redacted message leaves the thread read", () => {
// Given a message in a thread was redacted and everything is read // Given a message in a thread was redacted and everything is read
goTo(room1); goTo(room1);
@ -541,8 +541,7 @@ describe("Read receipts", () => {
// Then the room is unread // Then the room is unread
assertStillRead(room2); assertStillRead(room2);
}); });
// XXX: fails because the room still shows "1" even though we have read the thread (stuck unread) it("Reading a thread after a reaction to a redacted message marks the thread as read", () => {
it.skip("Reading a reaction to a redacted message marks the thread as read", () => {
// Given a redacted message in a thread exists, but someone reacted to it before it was redacted // Given a redacted message in a thread exists, but someone reacted to it before it was redacted
goTo(room1); goTo(room1);
receiveMessages(room2, [ receiveMessages(room2, [
@ -555,7 +554,7 @@ describe("Read receipts", () => {
receiveMessages(room2, [redactionOf("Msg3")]); receiveMessages(room2, [redactionOf("Msg3")]);
assertUnread(room2, 2); assertUnread(room2, 2);
// When we read the thread, creating a receipt that points at the reaction // When we read the thread
goTo(room2); goTo(room2);
openThread("Root"); openThread("Root");