From 893a5c971fd43186637f50cb3725eefa09b6d365 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johannes=20L=C3=B6thberg?= <johannes@kyriasis.com>
Date: Fri, 2 Dec 2016 19:58:35 +0100
Subject: [PATCH] Fix escaping markdown by rendering plaintext
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

We still need to parse "plaintext" messages through the markdown
renderer so that escappes are rendered properly.

Fixes vector-im/riot-web#2870.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
---
 src/Markdown.js                               | 32 ++++++++++++-------
 .../views/rooms/MessageComposerInput.js       |  8 +++--
 2 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/src/Markdown.js b/src/Markdown.js
index 18c888b541..2eb84b9041 100644
--- a/src/Markdown.js
+++ b/src/Markdown.js
@@ -56,23 +56,31 @@ export default class Markdown {
         return is_plain;
     }
 
-    toHTML() {
+    render(html) {
         const parser = new commonmark.Parser();
 
         const renderer = new commonmark.HtmlRenderer({safe: true});
         const real_paragraph = renderer.paragraph;
-        renderer.paragraph = function(node, entering) {
-            // If there is only one top level node, just return the
-            // bare text: it's a single line of text and so should be
-            // 'inline', rather than unnecessarily wrapped in its own
-            // p tag. If, however, we have multiple nodes, each gets
-            // its own p tag to keep them as separate paragraphs.
-            var par = node;
-            while (par.parent) {
-                par = par.parent
+        if (html) {
+            renderer.paragraph = function(node, entering) {
+                // If there is only one top level node, just return the
+                // bare text: it's a single line of text and so should be
+                // 'inline', rather than unnecessarily wrapped in its own
+                // p tag. If, however, we have multiple nodes, each gets
+                // its own p tag to keep them as separate paragraphs.
+                var par = node;
+                while (par.parent) {
+                    par = par.parent
+                }
+                if (par.firstChild != par.lastChild) {
+                    real_paragraph.call(this, node, entering);
+                }
             }
-            if (par.firstChild != par.lastChild) {
-                real_paragraph.call(this, node, entering);
+        } else {
+            renderer.paragraph = function(node, entering) {
+                if (entering) {
+                    this.lit('\n\n');
+                }
             }
         }
 
diff --git a/src/components/views/rooms/MessageComposerInput.js b/src/components/views/rooms/MessageComposerInput.js
index 37d937d6f5..5e8df592da 100644
--- a/src/components/views/rooms/MessageComposerInput.js
+++ b/src/components/views/rooms/MessageComposerInput.js
@@ -401,7 +401,7 @@ export default class MessageComposerInput extends React.Component {
         let contentState = null;
         if (enabled) {
             const md = new Markdown(this.state.editorState.getCurrentContent().getPlainText());
-            contentState = RichText.HTMLtoContentState(md.toHTML());
+            contentState = RichText.HTMLtoContentState(md.render(true));
         } else {
             let markdown = stateToMarkdown(this.state.editorState.getCurrentContent());
             if (markdown[markdown.length - 1] === '\n') {
@@ -523,8 +523,10 @@ export default class MessageComposerInput extends React.Component {
             );
         } else {
             const md = new Markdown(contentText);
-            if (!md.isPlainText()) {
-                contentHTML = md.toHTML();
+            if (md.isPlainText()) {
+                contentText = md.render(false);
+            } else {
+                contentHTML = md.render(true);
             }
         }