Merge pull request #3864 from matrix-org/jryans/complete-sec-confused

Adjust secret storage to work before sync
This commit is contained in:
J. Ryan Stinnett 2020-01-20 11:31:01 +00:00 committed by GitHub
commit 86a0a2e806
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View file

@ -107,7 +107,7 @@ export async function accessSecretStorage(func = async () => { }) {
cachingAllowed = true; cachingAllowed = true;
try { try {
if (!cli.hasSecretStorageKey()) { if (!await cli.hasSecretStorageKey()) {
// This dialog calls bootstrap itself after guiding the user through // This dialog calls bootstrap itself after guiding the user through
// passphrase creation. // passphrase creation.
const { finished } = Modal.createTrackedDialogAsync('Create Secret Storage dialog', '', const { finished } = Modal.createTrackedDialogAsync('Create Secret Storage dialog', '',

View file

@ -60,14 +60,14 @@ export default class CrossSigningPanel extends React.PureComponent {
this.setState(this._getUpdatedStatus()); this.setState(this._getUpdatedStatus());
}; };
_getUpdatedStatus() { async _getUpdatedStatus() {
// XXX: Add public accessors if we keep this around in production // XXX: Add public accessors if we keep this around in production
const cli = MatrixClientPeg.get(); const cli = MatrixClientPeg.get();
const crossSigning = cli._crypto._crossSigningInfo; const crossSigning = cli._crypto._crossSigningInfo;
const secretStorage = cli._crypto._secretStorage; const secretStorage = cli._crypto._secretStorage;
const crossSigningPublicKeysOnDevice = crossSigning.getId(); const crossSigningPublicKeysOnDevice = crossSigning.getId();
const crossSigningPrivateKeysInStorage = crossSigning.isStoredInSecretStorage(secretStorage); const crossSigningPrivateKeysInStorage = await crossSigning.isStoredInSecretStorage(secretStorage);
const secretStorageKeyInAccount = secretStorage.hasKey(); const secretStorageKeyInAccount = await secretStorage.hasKey();
return { return {
crossSigningPublicKeysOnDevice, crossSigningPublicKeysOnDevice,