From 86025459f40c661e4118d54d9e34eaaf19773e43 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Thu, 26 Nov 2020 15:01:12 +0000
Subject: [PATCH] Remove unused dialog, todo comments and other tiny tweaks

---
 .../views/auth/CustomServerDialog.js          | 47 -------------------
 .../dialogs/RegistrationEmailPromptDialog.tsx |  2 +-
 .../views/dialogs/ServerPickerDialog.tsx      |  2 +-
 src/components/views/elements/SSOButtons.tsx  |  1 -
 .../views/elements/ServerPicker.tsx           |  1 -
 5 files changed, 2 insertions(+), 51 deletions(-)
 delete mode 100644 src/components/views/auth/CustomServerDialog.js

diff --git a/src/components/views/auth/CustomServerDialog.js b/src/components/views/auth/CustomServerDialog.js
deleted file mode 100644
index 138f8c4689..0000000000
--- a/src/components/views/auth/CustomServerDialog.js
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
-Copyright 2015, 2016 OpenMarket Ltd
-Copyright 2019, 2020 The Matrix.org Foundation C.I.C.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-import React from 'react';
-import { _t } from '../../../languageHandler';
-import SdkConfig from '../../../SdkConfig';
-
-export default class CustomServerDialog extends React.Component {
-    render() {
-        const brand = SdkConfig.get().brand;
-        return (
-            <div className="mx_ErrorDialog">
-                <div className="mx_Dialog_title">
-                    { _t("Custom Server Options") }
-                </div>
-                <div className="mx_Dialog_content">
-                    <p>{_t(
-                        "You can use the custom server options to sign into other " +
-                        "Matrix servers by specifying a different homeserver URL. This " +
-                        "allows you to use %(brand)s with an existing Matrix account on a " +
-                        "different homeserver.",
-                        { brand },
-                    )}</p>
-                </div>
-                <div className="mx_Dialog_buttons">
-                    <button onClick={this.props.onFinished} autoFocus={true}>
-                        { _t("Dismiss") }
-                    </button>
-                </div>
-            </div>
-        );
-    }
-}
diff --git a/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx b/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
index 8e91a07bf5..b7cc81c113 100644
--- a/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
+++ b/src/components/views/dialogs/RegistrationEmailPromptDialog.tsx
@@ -67,7 +67,7 @@ const RegistrationEmailPromptDialog: React.FC<IProps> = ({onFinished}) => {
     >
         <div className="mx_Dialog_content" id="mx_RegistrationEmailPromptDialog">
             <p>{_t("Just a heads up, if you don't add an email and forget your password, you could " +
-                "<b>permanently lose access to your account.</b>", {}, {
+                "<b>permanently lose access to your account</b>.", {}, {
                 b: sub => <b>{sub}</b>,
             })}</p>
             <form onSubmit={onSubmit}>
diff --git a/src/components/views/dialogs/ServerPickerDialog.tsx b/src/components/views/dialogs/ServerPickerDialog.tsx
index 5a3a08670f..9eb819c98e 100644
--- a/src/components/views/dialogs/ServerPickerDialog.tsx
+++ b/src/components/views/dialogs/ServerPickerDialog.tsx
@@ -125,7 +125,7 @@ export default class ServerPickerDialog extends React.PureComponent<IProps, ISta
             return;
         }
 
-        this.props.onFinished(this.validatedConf); // TODO verify this even works
+        this.props.onFinished(this.validatedConf);
     };
 
     public render() {
diff --git a/src/components/views/elements/SSOButtons.tsx b/src/components/views/elements/SSOButtons.tsx
index 8247d17db8..a8bcc88412 100644
--- a/src/components/views/elements/SSOButtons.tsx
+++ b/src/components/views/elements/SSOButtons.tsx
@@ -46,7 +46,6 @@ const SSOButton: React.FC<ISSOButtonProps> = ({
 
     let icon;
     if (idp && idp.icon && idp.icon.startsWith("https://")) {
-        // TODO sanitize images
         icon = <img src={idp.icon} height="24" width="24" alt={label} />;
     }
 
diff --git a/src/components/views/elements/ServerPicker.tsx b/src/components/views/elements/ServerPicker.tsx
index b7fe7e8e84..7637ab7b8d 100644
--- a/src/components/views/elements/ServerPicker.tsx
+++ b/src/components/views/elements/ServerPicker.tsx
@@ -42,7 +42,6 @@ const showPickerDialog = (
 
 const onHelpClick = () => {
     Modal.createTrackedDialog('Custom Server Dialog', '', InfoDialog, {
-        // TODO
         title: _t("Server Options"),
         description: _t("You can use the custom server options to sign into other Matrix servers by specifying " +
             "a different homeserver URL. This allows you to use Element with an existing Matrix account on " +