PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

misc code quality improvements

Browse source
This commit is contained in:
Travis Ralston 2020-06-10 18:56:21 -06:00
parent 6ccb566587
commit 853ae6d5bf
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/stores/MessagePreviewStore.ts
View file

@ -20,7 +20,7 @@ import { AsyncStoreWithClient } from "./AsyncStoreWithClient";
import defaultDispatcher from "../dispatcher/dispatcher"; import defaultDispatcher from "../dispatcher/dispatcher";
import { RoomListStoreTempProxy } from "./room-list/RoomListStoreTempProxy"; import { RoomListStoreTempProxy } from "./room-list/RoomListStoreTempProxy";
import { textForEvent } from "../TextForEvent"; import { textForEvent } from "../TextForEvent";
import { MatrixEvent } from "matrix-js-sdk/src/models/Event"; import { MatrixEvent } from "matrix-js-sdk/src/models/event";
import { _t } from "../languageHandler"; import { _t } from "../languageHandler";
const PREVIEWABLE_EVENTS = [ const PREVIEWABLE_EVENTS = [
@ -40,8 +40,11 @@ const PREVIEWABLE_EVENTS = [
{type: "m.room.create", isState: true}, {type: "m.room.create", isState: true},
]; ];
// The maximum number of events we're willing to look back on to get a preview.
const MAX_EVENTS_BACKWARDS = 50;
interface IState { interface IState {
[roomId: string]: string; [roomId: string]: string | null; // null indicates the preview is empty
} }
export class MessagePreviewStore extends AsyncStoreWithClient<IState> { export class MessagePreviewStore extends AsyncStoreWithClient<IState> {
@ -64,6 +67,8 @@ export class MessagePreviewStore extends AsyncStoreWithClient<IState> {
if (!room) return null; // invalid room, just return nothing if (!room) return null; // invalid room, just return nothing
// It's faster to do a lookup this way than it is to use Object.keys().includes() // It's faster to do a lookup this way than it is to use Object.keys().includes()
// We only want to generate a preview if there's one actually missing and not explicitly
// set as 'none'.
const val = this.state[room.roomId]; const val = this.state[room.roomId];
if (val !== null && typeof(val) !== "string") { if (val !== null && typeof(val) !== "string") {
this.generatePreview(room); this.generatePreview(room);
@ -73,14 +78,12 @@ export class MessagePreviewStore extends AsyncStoreWithClient<IState> {
} }
private generatePreview(room: Room) { private generatePreview(room: Room) {
const maxEventsBackwards = 50; // any further and we just assume there's nothing important
const timeline = room.getLiveTimeline(); const timeline = room.getLiveTimeline();
if (!timeline) return; // usually only happens in tests if (!timeline) return; // usually only happens in tests
const events = timeline.getEvents(); const events = timeline.getEvents();
for (let i = events.length - 1; i >= 0; i--) { for (let i = events.length - 1; i >= 0; i--) {
if (i === events.length - maxEventsBackwards) return; // limit reached if (i === events.length - MAX_EVENTS_BACKWARDS) return; // limit reached
const event = events[i]; const event = events[i];
const preview = this.generatePreviewForEvent(event); const preview = this.generatePreviewForEvent(event);