PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix: flaky percy test "Rendering permalinks" (#10874)

Browse source 
* hide timestamp

* retrigger sonar

* trigger build

* hide elements instead of removing them which might effect scroll

* lint
This commit is contained in:
Kerry 2023-05-19 14:53:44 +12:00 committed by GitHub
parent 55336bf932
commit 8513d2f4ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
cypress/e2e/permalinks/permalinks.spec.ts
View file

@ -126,13 +126,14 @@ describe("permalinks", () => {
getPill(danielle.getSafeUserId()); getPill(danielle.getSafeUserId());
}); });
// clean up before taking the snapshot // Exclude various components from the snapshot, for consistency
cy.get(".mx_cryptoEvent").invoke("remove"); const percyCSS =
cy.get(".mx_NewRoomIntro").invoke("remove"); ".mx_cryptoEvent, " +
cy.get(".mx_GenericEventListSummary").invoke("remove"); ".mx_NewRoomIntro, " +
".mx_MessageTimestamp, " +
".mx_RoomView_myReadMarker, " +
".mx_GenericEventListSummary { visibility: hidden !important; }";
// Disabled because flaky - see https://github.com/vector-im/element-web/issues/25283 cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
//const percyCSS = ".mx_MessageTimestamp, .mx_MessagePanel_myReadMarker { visibility: hidden !important; }";
//cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS });
}); });
}); });