PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix compound typography font component issues (#12826)

Browse source 
* Fix compound typography font component issues

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update playwright tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2024-07-29 12:19:26 +01:00 committed by GitHub
parent 4e6b1c82e2
commit 844da7a656
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
playwright/e2e/app-loading/feature-detection.spec.ts
View file

@ -21,9 +21,9 @@ test(`shows error page if browser lacks Intl support`, async ({ page }) => {
await page.goto("/"); await page.goto("/");
// Lack of Intl support causes the app bundle to fail to load, so we get the iframed // Lack of Intl support causes the app bundle to fail to load, so we get the iframed
// static error page and need to explicitly look in the iframe becuse Playwright doesn't // static error page and need to explicitly look in the iframe because Playwright doesn't
// recurse into iframes when looking for elements // recurse into iframes when looking for elements
const header = await page.frameLocator("iframe").getByText("Unsupported browser"); const header = page.frameLocator("iframe").getByText("Unsupported browser");
await expect(header).toBeVisible(); await expect(header).toBeVisible();
await expect(page).toMatchScreenshot("unsupported-browser.png"); await expect(page).toMatchScreenshot("unsupported-browser.png");
@ -34,8 +34,8 @@ test(`shows error page if browser lacks WebAssembly support`, async ({ page }) =
await page.goto("/"); await page.goto("/");
// Lack of WebAssembly support doesn't cause the bundle to fail loading, so we get // Lack of WebAssembly support doesn't cause the bundle to fail loading, so we get
// CompatibilityView, ie. no iframes. // CompatibilityView, i.e. no iframes.
const header = await page.getByText("Unsupported browser"); const header = page.getByText("Unsupported browser");
await expect(header).toBeVisible(); await expect(header).toBeVisible();
await expect(page).toMatchScreenshot("unsupported-browser-CompatibilityView.png"); await expect(page).toMatchScreenshot("unsupported-browser-CompatibilityView.png");

BIN
playwright/snapshots/app-loading/feature-detection.spec.ts/unsupported-browser-CompatibilityView-linux.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 69 KiB

After

Width:  |  Height:  |  Size: 94 KiB

2
res/css/_common.pcss
View file

@ -25,8 +25,6 @@ limitations under the License.
@import url("maplibre-gl/dist/maplibre-gl.css"); @import url("maplibre-gl/dist/maplibre-gl.css");
:root { :root {
font-size: 10px;
--container-border-width: 8px; --container-border-width: 8px;
--container-gap-width: 8px; /* only even numbers should be used because otherwise we get 0.5px margin values. */ --container-gap-width: 8px; /* only even numbers should be used because otherwise we get 0.5px margin values. */
--transition-short: 0.1s; --transition-short: 0.1s;