PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Mute "Unknown room caused setting update" spam

Browse source 
See comment enclosed within.

Fixes https://github.com/vector-im/riot-web/issues/14254
This commit is contained in:
Travis Ralston 2020-07-07 13:42:15 -06:00
parent a49b5109c6
commit 7963ed6d04
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/settings/handlers/RoomSettingsHandler.js
View file

@ -43,11 +43,14 @@ export default class RoomSettingsHandler extends MatrixClientBackedSettingsHandl
const roomId = event.getRoomId(); const roomId = event.getRoomId();
const room = this.client.getRoom(roomId); const room = this.client.getRoom(roomId);
// Note: the tests often fire setting updates that don't have rooms in the store, so // Note: in tests and during the encryption setup on initial load we might not have
// we fail softly here. We shouldn't assume that the state being fired is current // rooms in the store, so we just quietly ignore the problem. If we log it then we'll
// state, but we also don't need to explode just because we didn't find a room. // just end up spamming the logs a few thousand times. It is perfectly fine for us
if (!room) console.warn(`Unknown room caused setting update: ${roomId}`); // to ignore the problem as the app will not have loaded enough to care yet.
if (room && state !== room.currentState) return; // ignore state updates which are not current if (!room) return;
// ignore state updates which are not current
if (room && state !== room.currentState) return;
if (event.getType() === "org.matrix.room.preview_urls") { if (event.getType() === "org.matrix.room.preview_urls") {
let val = event.getContent()['disable']; let val = event.getContent()['disable'];