From 7845a6350655bf4c1fc01676390968ab4206f3dd Mon Sep 17 00:00:00 2001 From: David Baker Date: Thu, 14 Feb 2019 15:53:52 +0000 Subject: [PATCH] Remove 'welcome' from top-left menu Tjis is quite confusing as the welcome page is designed for when you're not logged in, ie. has a sign-in button. There's also no way to get back into the app so it really looks like it's logged you out. Reverts 116367fd69 --- res/css/views/context_menus/_TopLeftMenu.scss | 4 ---- res/img/feather-icons/gift.svg | 1 - src/components/views/context_menus/TopLeftMenu.js | 10 ---------- src/i18n/strings/en_EN.json | 1 - 4 files changed, 16 deletions(-) delete mode 100644 res/img/feather-icons/gift.svg diff --git a/res/css/views/context_menus/_TopLeftMenu.scss b/res/css/views/context_menus/_TopLeftMenu.scss index b3ef703144..272a882051 100644 --- a/res/css/views/context_menus/_TopLeftMenu.scss +++ b/res/css/views/context_menus/_TopLeftMenu.scss @@ -31,10 +31,6 @@ limitations under the License. mask-image: url('$(res)/img/feather-icons/home.svg'); } - li.mx_TopLeftMenu_icon_welcome::after { - mask-image: url('$(res)/img/feather-icons/gift.svg'); - } - li.mx_TopLeftMenu_icon_settings::after { mask-image: url('$(res)/img/feather-icons/settings.svg'); } diff --git a/res/img/feather-icons/gift.svg b/res/img/feather-icons/gift.svg deleted file mode 100644 index c225b50f9d..0000000000 --- a/res/img/feather-icons/gift.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/src/components/views/context_menus/TopLeftMenu.js b/src/components/views/context_menus/TopLeftMenu.js index 8583f631f2..56f5ba5c6f 100644 --- a/src/components/views/context_menus/TopLeftMenu.js +++ b/src/components/views/context_menus/TopLeftMenu.js @@ -25,8 +25,6 @@ import MatrixClientPeg from '../../../MatrixClientPeg'; export class TopLeftMenu extends React.Component { constructor() { super(); - this.viewHomePage = this.viewHomePage.bind(this); - this.viewWelcomePage = this.viewWelcomePage.bind(this); this.openSettings = this.openSettings.bind(this); this.signIn = this.signIn.bind(this); this.signOut = this.signOut.bind(this); @@ -67,9 +65,6 @@ export class TopLeftMenu extends React.Component { return
{homePageSection} - @@ -82,11 +77,6 @@ export class TopLeftMenu extends React.Component { this.closeMenu(); } - viewWelcomePage() { - dis.dispatch({action: 'view_welcome_page'}); - this.closeMenu(); - } - openSettings() { dis.dispatch({action: 'view_user_settings'}); this.closeMenu(); diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index fe41beb7ae..ef705dab78 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1221,7 +1221,6 @@ "View Community": "View Community", "Hide": "Hide", "Sign in": "Sign in", - "Welcome": "Welcome", "Login": "Login", "powered by Matrix": "powered by Matrix", "Robot check is currently unavailable on desktop - please use a web browser": "Robot check is currently unavailable on desktop - please use a web browser",