From 753fc2d33ace1d5f0775242805ece5e648e1cfa8 Mon Sep 17 00:00:00 2001 From: Florian Duros Date: Mon, 11 Mar 2024 16:48:11 +0100 Subject: [PATCH] TAC: Fix CSS & component typos (#12333) * Fix CSS & component typo * Update snapshots --- res/css/structures/_ThreadsActivityCentre.pcss | 4 ++-- .../threads-activity-centre/ThreadsActivityCentre.tsx | 8 ++++---- .../__snapshots__/ThreadsActivityCentre-test.tsx.snap | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/res/css/structures/_ThreadsActivityCentre.pcss b/res/css/structures/_ThreadsActivityCentre.pcss index 4f723700f2..4c61d32f77 100644 --- a/res/css/structures/_ThreadsActivityCentre.pcss +++ b/res/css/structures/_ThreadsActivityCentre.pcss @@ -62,12 +62,12 @@ } } -.mx_ThreadsActivity_rows { +.mx_ThreadsActivityCentre_rows { overflow-y: scroll; /* Let some space at the top and the bottom of the pop-up */ max-height: calc(100vh - 200px); - .mx_ThreadsActivityRow { + .mx_ThreadsActivityCentreRow { height: 48px; /* Make the label of the MenuItem stay on one line and truncate with ellipsis if needed */ diff --git a/src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx b/src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx index debf845164..098f2d828c 100644 --- a/src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx +++ b/src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx @@ -84,9 +84,9 @@ export function ThreadsActivityCentre({ displayButtonLabel }: ThreadsActivityCen } > {/* Make the content of the pop-up scrollable */} -
+
{roomsAndNotifications.rooms.map(({ room, notificationLevel }) => ( - { onClick(); diff --git a/test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap b/test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap index cbcb4bd6a1..5b9e2091b7 100644 --- a/test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap +++ b/test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap @@ -23,10 +23,10 @@ exports[`ThreadsActivityCentre renders notifications matching the snapshot 1`] = Threads activity