PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Enable tests that have been fixed by matrix-js-sdk#3798 (#11762)

Browse source 
* Disable two tests that flake after matrix-js-sdk#3798

* Enable tests that have been fixed by matrix-js-sdk#3798

* Disable two flaking tests

* Disable another flaking test
This commit is contained in:
Andy Balaam 2023-10-18 17:12:35 +01:00 committed by GitHub
parent 888d01cad8
commit 73f91cbafa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
cypress/e2e/read-receipts/redactions.spec.ts
View file

@ -156,8 +156,7 @@ describe("Read receipts", () => {
// Then it becomes read // Then it becomes read
assertStillRead(room2); assertStillRead(room2);
}); });
// XXX: failed because it flakes saying 2 unread when it should be 1 it("Marking an unread room as read after a redaction makes it read", () => {
it.skip("Marking an unread room as read after a redaction makes it read", () => {
// Given an unread room where latest message is redacted // Given an unread room where latest message is redacted
goTo(room1); goTo(room1);
receiveMessages(room2, ["Msg1", "Msg2"]); receiveMessages(room2, ["Msg1", "Msg2"]);
@ -221,8 +220,7 @@ describe("Read receipts", () => {
// Then the unread count goes down again // Then the unread count goes down again
assertUnread(room2, 1); assertUnread(room2, 1);
}); });
// XXX: fails because it flakes saying 2 unread instead of 1 it("Redacting one of the unread messages reduces the unread count after restart", () => {
it.skip("Redacting one of the unread messages reduces the unread count after restart", () => {
// Given unread count was reduced by redacting messages // Given unread count was reduced by redacting messages
goTo(room1); goTo(room1);
receiveMessages(room2, ["Msg1", "Msg2", "Msg3"]); receiveMessages(room2, ["Msg1", "Msg2", "Msg3"]);
@ -384,8 +382,7 @@ describe("Read receipts", () => {
goTo(room2); goTo(room2);
assertReadThread("Root"); assertReadThread("Root");
}); });
// XXX: fails because it flakes (on CI only)
// XXX: fails because the unread count is still 1 when it should be 0 (this is a genuine stuck unread case)
it.skip("Reading an unread thread after a redaction of the latest message makes it read", () => { it.skip("Reading an unread thread after a redaction of the latest message makes it read", () => {
// Given an unread thread where the latest message was redacted // Given an unread thread where the latest message was redacted
goTo(room1); goTo(room1);
@ -431,7 +428,7 @@ describe("Read receipts", () => {
// Then the room is still read // Then the room is still read
assertRead(room2); assertRead(room2);
}); });
// XXX: fails because the unread count is still 1 when it should be 0 // XXX: fails because it flakes (on CI only)
it.skip("Reading an unread thread after a redaction of an older message makes it read", () => { it.skip("Reading an unread thread after a redaction of an older message makes it read", () => {
// Given an unread thread where an older message was redacted // Given an unread thread where an older message was redacted
goTo(room1); goTo(room1);
@ -453,7 +450,7 @@ describe("Read receipts", () => {
goTo(room2); goTo(room2);
assertReadThread("Root"); assertReadThread("Root");
}); });
// XXX: fails because the room has an unread dot after I marked it as read // XXX: fails because it flakes (on CI only)
it.skip("Marking an unread thread as read after a redaction makes it read", () => { it.skip("Marking an unread thread as read after a redaction makes it read", () => {
// Given an unread thread where an older message was redacted // Given an unread thread where an older message was redacted
goTo(room1); goTo(room1);