PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Deflake verification playwright tests (#12669)

Browse source 
Turns out the sleep that got removed in
https://github.com/matrix-org/matrix-react-sdk/pull/12667 was useful.
This commit is contained in:
Richard van der Hoff 2024-06-21 17:58:38 +01:00 committed by GitHub
parent 5eb5ea81d5
commit 736b083a79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
playwright/e2e/crypto/utils.ts
View file

@ -113,6 +113,13 @@ export async function checkDeviceIsConnectedKeyBackup(
expectedBackupVersion: string, expectedBackupVersion: string,
checkBackupKeyInCache: boolean, checkBackupKeyInCache: boolean,
): Promise<void> { ): Promise<void> {
// Sanity check the given backup version: if it's null, something went wrong earlier in the test.
if (!expectedBackupVersion) {
throw new Error(
`Invalid backup version passed to \`checkDeviceIsConnectedKeyBackup\`: ${expectedBackupVersion}`,
);
}
await page.getByRole("button", { name: "User menu" }).click(); await page.getByRole("button", { name: "User menu" }).click();
await page.locator(".mx_UserMenu_contextMenu").getByRole("menuitem", { name: "Security & Privacy" }).click(); await page.locator(".mx_UserMenu_contextMenu").getByRole("menuitem", { name: "Security & Privacy" }).click();
await expect(page.locator(".mx_Dialog").getByRole("button", { name: "Restore from Backup" })).toBeVisible(); await expect(page.locator(".mx_Dialog").getByRole("button", { name: "Restore from Backup" })).toBeVisible();

14
playwright/e2e/crypto/verification.spec.ts
View file

@ -50,11 +50,17 @@ test.describe("Device verification", () => {
bootstrapSecretStorage: true, bootstrapSecretStorage: true,
}); });
aliceBotClient.setCredentials(credentials); aliceBotClient.setCredentials(credentials);
const mxClientHandle = await aliceBotClient.prepareClient();
expectedBackupVersion = await mxClientHandle.evaluate(async (mxClient) => { // Backup is prepared in the background. Poll until it is ready.
return await mxClient.getCrypto()!.getActiveSessionBackupVersion(); const botClientHandle = await aliceBotClient.prepareClient();
}); await expect
.poll(async () => {
expectedBackupVersion = await botClientHandle.evaluate((cli) =>
cli.getCrypto()!.getActiveSessionBackupVersion(),
);
return expectedBackupVersion;
})
.not.toBe(null);
}); });
// Click the "Verify with another device" button, and have the bot client auto-accept it. // Click the "Verify with another device" button, and have the bot client auto-accept it.