PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Don't assume that diffs will have an appropriate child node

Browse source 
Fixes https://github.com/vector-im/riot-web/issues/11497

This is a regression from react-sdk v1.5.0 where the diff feature was added in the first place. It only affects lists.
This commit is contained in:
Travis Ralston 2019-11-27 12:26:43 -07:00
parent fbba55ab05
commit 673e6c3162
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/utils/MessageDiffUtils.js
View file

@ -77,6 +77,8 @@ function findRefNodes(root, route, isAddition) {
const end = isAddition ? route.length - 1 : route.length; const end = isAddition ? route.length - 1 : route.length;
for (let i = 0; i < end; ++i) { for (let i = 0; i < end; ++i) {
refParentNode = refNode; refParentNode = refNode;
// Lists don't have appropriate child nodes we can use.
if (!refNode.childNodes[route[i]]) continue;
refNode = refNode.childNodes[route[i]]; refNode = refNode.childNodes[route[i]];
} }
return {refNode, refParentNode}; return {refNode, refParentNode};