PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Safely grab the OpenGraph title out of the URL preview for link safety (#9028)

Browse source
This commit is contained in:
Travis Ralston 2022-07-11 12:53:45 -06:00 committed by GitHub
parent 0bc2f1c101
commit 62f3a9ae05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/components/views/rooms/LinkPreviewWidget.tsx
View file

@ -120,8 +120,9 @@ export default class LinkPreviewWidget extends React.Component<IProps> {
// opaque string. This does not allow any HTML to be injected into the DOM. // opaque string. This does not allow any HTML to be injected into the DOM.
const description = AllHtmlEntities.decode(p["og:description"] || ""); const description = AllHtmlEntities.decode(p["og:description"] || "");
const anchor = <a href={this.props.link} target="_blank" rel="noreferrer noopener">{ p["og:title"] }</a>; const title = p["og:title"]?.trim() ?? "";
const needsTooltip = PlatformPeg.get()?.needsUrlTooltips() && this.props.link !== p["og:title"].trim(); const anchor = <a href={this.props.link} target="_blank" rel="noreferrer noopener">{ title }</a>;
const needsTooltip = PlatformPeg.get()?.needsUrlTooltips() && this.props.link !== title;
return ( return (
<div className="mx_LinkPreviewWidget"> <div className="mx_LinkPreviewWidget">