PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Improve timing safety of useLatestResult test (#8915)

Browse source 
and fix contains to be equals instead, as it's *possible* we can accidentally punch in 20 or something and still have the test pass.
This commit is contained in:
Travis Ralston 2022-06-28 15:29:01 +02:00 committed by GitHub
parent 7f7ad10b04
commit 60d3d41184
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
test/hooks/useLatestResult-test.tsx
View file

@ -47,20 +47,20 @@ describe("useLatestResult", () => {
await act(async () => { await act(async () => {
await sleep(25); await sleep(25);
}); });
expect(wrapper.text()).toContain("0"); expect(wrapper.text()).toEqual("0");
wrapper.setProps({ doRequest, query: 1 }); wrapper.setProps({ doRequest, query: 1 });
await act(async () => { await act(async () => {
await sleep(15); await sleep(10);
}); });
wrapper.setProps({ doRequest, query: 2 }); wrapper.setProps({ doRequest, query: 2 });
await act(async () => { await act(async () => {
await sleep(15); await sleep(10);
}); });
expect(wrapper.text()).toContain("0"); expect(wrapper.text()).toEqual("0");
await act(async () => { await act(async () => {
await sleep(15); await sleep(15);
}); });
expect(wrapper.text()).toContain("2"); expect(wrapper.text()).toEqual("2");
}); });
it("should prevent out-of-order results", async () => { it("should prevent out-of-order results", async () => {
@ -73,7 +73,7 @@ describe("useLatestResult", () => {
await act(async () => { await act(async () => {
await sleep(5); await sleep(5);
}); });
expect(wrapper.text()).toContain("0"); expect(wrapper.text()).toEqual("0");
wrapper.setProps({ doRequest, query: 50 }); wrapper.setProps({ doRequest, query: 50 });
await act(async () => { await act(async () => {
await sleep(5); await sleep(5);
@ -82,10 +82,10 @@ describe("useLatestResult", () => {
await act(async () => { await act(async () => {
await sleep(5); await sleep(5);
}); });
expect(wrapper.text()).toContain("1"); expect(wrapper.text()).toEqual("1");
await act(async () => { await act(async () => {
await sleep(50); await sleep(50);
}); });
expect(wrapper.text()).toContain("1"); expect(wrapper.text()).toEqual("1");
}); });
}); });