Iterate PR some more

This commit is contained in:
Michael Telatynski 2020-11-26 15:45:15 +00:00
parent 86025459f4
commit 5f03cbd88f
2 changed files with 7 additions and 8 deletions

View file

@ -341,13 +341,14 @@ export default class LoginComponent extends React.PureComponent<IProps, IState>
onTryRegisterClick = ev => { onTryRegisterClick = ev => {
const hasPasswordFlow = this.state.flows.find(flow => flow.type === "m.login.password"); const hasPasswordFlow = this.state.flows.find(flow => flow.type === "m.login.password");
if (!hasPasswordFlow) { const ssoFlow = this.state.flows.find(flow => flow.type === "m.login.sso" || flow.type === "m.login.cas");
// If we're showing SSO it means that registration is also probably disabled, // If has no password flow but an SSO flow guess that the user wants to register with SSO.
// so intercept the click and instead pretend the user clicked 'Sign in with SSO'. // TODO: instead hide the Register button if registration is disabled by checking with the server,
// has no specific errCode currently and uses M_FORBIDDEN.
if (ssoFlow && !hasPasswordFlow) {
ev.preventDefault(); ev.preventDefault();
ev.stopPropagation(); ev.stopPropagation();
const step = this.state.flows.find(flow => flow.type === "m.login.sso" || flow.type === "m.login.cas"); const ssoKind = ssoFlow.type === 'm.login.sso' ? 'sso' : 'cas';
const ssoKind = step.type === 'm.login.sso' ? 'sso' : 'cas';
PlatformPeg.get().startSingleSignOn(this.loginLogic.createTemporaryClient(), ssoKind, PlatformPeg.get().startSingleSignOn(this.loginLogic.createTemporaryClient(), ssoKind,
this.props.fragmentAfterLogin); this.props.fragmentAfterLogin);
} else { } else {

View file

@ -2112,7 +2112,7 @@
"This wasn't me": "This wasn't me", "This wasn't me": "This wasn't me",
"Doesn't look like a valid email address": "Doesn't look like a valid email address", "Doesn't look like a valid email address": "Doesn't look like a valid email address",
"Continuing without email": "Continuing without email", "Continuing without email": "Continuing without email",
"Just a heads up, if you don't add an email and forget your password, you could <b>permanently lose access to your account.</b>": "Just a heads up, if you don't add an email and forget your password, you could <b>permanently lose access to your account.</b>", "Just a heads up, if you don't add an email and forget your password, you could <b>permanently lose access to your account</b>.": "Just a heads up, if you don't add an email and forget your password, you could <b>permanently lose access to your account</b>.",
"Email (optional)": "Email (optional)", "Email (optional)": "Email (optional)",
"Please fill why you're reporting.": "Please fill why you're reporting.", "Please fill why you're reporting.": "Please fill why you're reporting.",
"Report Content to Your Homeserver Administrator": "Report Content to Your Homeserver Administrator", "Report Content to Your Homeserver Administrator": "Report Content to Your Homeserver Administrator",
@ -2284,8 +2284,6 @@
"powered by Matrix": "powered by Matrix", "powered by Matrix": "powered by Matrix",
"This homeserver would like to make sure you are not a robot.": "This homeserver would like to make sure you are not a robot.", "This homeserver would like to make sure you are not a robot.": "This homeserver would like to make sure you are not a robot.",
"Country Dropdown": "Country Dropdown", "Country Dropdown": "Country Dropdown",
"Custom Server Options": "Custom Server Options",
"You can use the custom server options to sign into other Matrix servers by specifying a different homeserver URL. This allows you to use %(brand)s with an existing Matrix account on a different homeserver.": "You can use the custom server options to sign into other Matrix servers by specifying a different homeserver URL. This allows you to use %(brand)s with an existing Matrix account on a different homeserver.",
"Confirm your identity by entering your account password below.": "Confirm your identity by entering your account password below.", "Confirm your identity by entering your account password below.": "Confirm your identity by entering your account password below.",
"Password": "Password", "Password": "Password",
"Missing captcha public key in homeserver configuration. Please report this to your homeserver administrator.": "Missing captcha public key in homeserver configuration. Please report this to your homeserver administrator.", "Missing captcha public key in homeserver configuration. Please report this to your homeserver administrator.": "Missing captcha public key in homeserver configuration. Please report this to your homeserver administrator.",