PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Improve performance of tag panel selection (when tags are selected)

Browse source 
Deselecting all tags is now slightly less performant than selecting a tag
but mostly due to the number of RoomTiles being rendered.

Swapping between different tags (a supposed common use-case) feels much
more spritely!
This commit is contained in:
lukebarnard 2018-01-03 17:12:31 +00:00
parent 63335f70e5
commit 5c5307c665
1 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/components/views/rooms/RoomList.js
View file

@ -311,11 +311,6 @@ module.exports = React.createClass({
});
},
isRoomInSelectedTags: function(room) {
// No selected tags = every room is visible in the list
return this.state.selectedTags.length === 0 || this._visibleRooms.includes(room.roomId);
},
refreshRoomList: function() {
// TODO: ideally we'd calculate this once at start, and then maintain
// any changes to it incrementally, updating the appropriate sublists
@ -344,7 +339,26 @@ module.exports = React.createClass({
lists["im.vector.fake.archived"] = [];
const dmRoomMap = DMRoomMap.shared();
MatrixClientPeg.get().getRooms().forEach((room) => {
// If there are any tags selected, constrain the rooms listed to the
// visible rooms as determined by this._visibleRooms. Here, we
// de-duplicate and filter out rooms that the client doesn't know
// about (hence the Set and the null-guard on `room`).
let rooms = [];
if (this.state.selectedTags.length > 0) {
const roomSet = new Set();
this._visibleRooms.forEach((roomId) => {
const room = MatrixClientPeg.get().getRoom(roomId);
if (room) {
roomSet.add(room);
}
});
rooms = Array.from(roomSet);
} else {
rooms = MatrixClientPeg.get().getRooms();
}
rooms.forEach((room, index) => {
const me = room.getMember(MatrixClientPeg.get().credentials.userId);
if (!me) return;
@ -362,11 +376,6 @@ module.exports = React.createClass({
// Used to split rooms via tags
const tagNames = Object.keys(room.tags);
// Apply TagPanel filtering, derived from FilterStore
if (!this.isRoomInSelectedTags(room)) {
return;
}
if (tagNames.length) {
for (let i = 0; i < tagNames.length; i++) {
const tagName = tagNames[i];