PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Restore createRoom.canEncryptToAllUsers (#10491)

Browse source
This commit is contained in:
Michael Weimann 2023-04-03 11:28:17 +02:00 committed by GitHub
parent 6ac366ee5a
commit 56423d4d53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/createRoom.ts
View file

@ -399,11 +399,9 @@ export async function canEncryptToAllUsers(client: MatrixClient, userIds: string
try { try {
const usersDeviceMap = await client.downloadKeys(userIds); const usersDeviceMap = await client.downloadKeys(userIds);
// There are no devices at all.
if (usersDeviceMap.size === 0) return false;
for (const devices of usersDeviceMap.values()) { for (const devices of usersDeviceMap.values()) {
if (devices.size === 0) { if (devices.size === 0) {
// This user does not have any encryption-capable devices.
return false; return false;
} }
} }

10
test/createRoom-test.ts
View file

@ -161,10 +161,16 @@ describe("canEncryptToAllUsers", () => {
client = mocked(stubClient()); client = mocked(stubClient());
}); });
it("should return false if download keys does not return any user", async () => { it("should return true if userIds is empty", async () => {
client.downloadKeys.mockResolvedValue(new Map());
const result = await canEncryptToAllUsers(client, []);
expect(result).toBe(true);
});
it("should return true if download keys does not return any user", async () => {
client.downloadKeys.mockResolvedValue(new Map()); client.downloadKeys.mockResolvedValue(new Map());
const result = await canEncryptToAllUsers(client, [user1Id, user2Id]); const result = await canEncryptToAllUsers(client, [user1Id, user2Id]);
expect(result).toBe(false); expect(result).toBe(true);
}); });
it("should return false if none of the users has a device", async () => { it("should return false if none of the users has a device", async () => {