PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Don't send a poll response event if you are voting for your current c… (#7326)

Browse source
This commit is contained in:
Andy Balaam 2021-12-10 12:36:53 +00:00 committed by GitHub
parent a727961c43
commit 5554d7fdc1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/views/messages/MPollBody.tsx
View file

@ -223,10 +223,13 @@ export default class MPollBody extends React.Component<IBodyProps, IState> {
};
private selectOption(answerId: string) {
if (answerId === this.state.selected) {
if (this.isEnded()) {
return;
}
if (this.isEnded()) {
const userVotes = this.collectUserVotes();
const userId = this.context.getUserId();
const myVote = userVotes.get(userId)?.answers[0];
if (answerId === myVote) {
return;
}

22
test/components/views/messages/MPollBody-test.tsx
View file

@ -497,6 +497,28 @@ describe("MPollBody", () => {
]);
});
it("sends no vote event when I click what I already chose", () => {
const receivedEvents = [];
MatrixClientPeg.matrixClient.sendEvent = (
roomId: string,
eventType: string,
content: IContent,
txnId?: string,
callback?: Callback,
): Promise<ISendEventResponse> => {
receivedEvents.push( { roomId, eventType, content, txnId, callback } );
return Promise.resolve({ "event_id": "fake_tracked_send_id" });
};
const votes = [responseEvent("@me:example.com", "wings")];
const body = newMPollBody(votes);
clickRadio(body, "wings");
clickRadio(body, "wings");
clickRadio(body, "wings");
clickRadio(body, "wings");
expect(receivedEvents).toEqual([]);
});
it("sends several events when I click different options", () => {
const receivedEvents = [];
MatrixClientPeg.matrixClient.sendEvent = (